| Message ID | 20181227060553.11195-1-jerinj@marvell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E3783257; Thu, 27 Dec 2018 07:06:56 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9ED7D3256 for <dev@dpdk.org>; Thu, 27 Dec 2018 07:06:54 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBR6568a024855; Wed, 26 Dec 2018 22:06:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=jD9DV+7Oj5Jqee+mCxqI6T2dWxMIe6I8n+s6m9arM0o=; b=yPzdCC2g4K0lEx3oIDxnUNlhnVEM++Ci+jPt+dzn7+UUhUobpl1aFuMcYcMPCURrEvqI OGYPM8aly8pTrifVoTTWA2I0W81PnHmJssW27o40AFZUaxsaZJinpiZuPgV6miC510qa coHrDkzha8pRNhS2WCiKNkvl2g7JxkAjohqyazqjP7IHMlPk9TXthpYVjgWkNWcFUBPr wbooK15cYKRjlsd22fLq7ErvGaSNnt1hA4CPtI84Z9kea/0D3rVwBZtmyXZi2uXINFI7 XKDyIhkXvZDJTOo0aT7yrWDdiHeuA0OJg5Ufc+KzO57SkAI9V7vBP5Ab7A0cApjub0kZ yw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2pkmmf03n9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 26 Dec 2018 22:06:53 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 26 Dec 2018 22:06:52 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 26 Dec 2018 22:06:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jD9DV+7Oj5Jqee+mCxqI6T2dWxMIe6I8n+s6m9arM0o=; b=Zqi5FE9LvkFSTKXnHkFGoFs/huof2t86x89h2BjN9XmXONbc1GWlzRwOXK/yrjviB/OtPUCSuHBWLV9omH+QNQwIqZafOKqGKDGJSugNulQoGN45xetkmMAq7k/8K0dAQgzlKiKbfs8pn1jC/WUcWhFs5OYDtt9tFa0NEpbXW3I= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2901.namprd18.prod.outlook.com (20.179.58.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Thu, 27 Dec 2018 06:06:48 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1d21:75dc:c1d9:65f1]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1d21:75dc:c1d9:65f1%2]) with mapi id 15.20.1471.019; Thu, 27 Dec 2018 06:06:48 +0000 From: Jerin Jacob Kollanukkaran <jerinj@marvell.com> To: Qiming Yang <qiming.yang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com> Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix build with debug enabled Thread-Index: AQHUnapalDAg3UzSBEWTJiOHdsIk/Q== Date: Thu, 27 Dec 2018 06:06:48 +0000 Message-ID: <20181227060553.11195-1-jerinj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0012.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:21::22) To BYAPR18MB2424.namprd18.prod.outlook.com (2603:10b6:a03:130::21) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [106.208.111.21] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR18MB2901; 20:cuJQdZe5W1zQ44DXu0/OCUE0ZZ/FEXg4avbO3giMiRObdGuELWcXyI90rTYd232G8NjwvJvpGBsGjNguCD0oyLUgPKoZrqNA0KPTBLllaopiXGHMLc40HhkqnlqwgsDQwJPzO19oQxYFpGczxyExtNsQ816aQ5vF74gD68yULrU= x-ms-office365-filtering-correlation-id: 51e59a26-34d2-45c5-68c8-08d66bc17c66 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR18MB2901; x-ms-traffictypediagnostic: BYAPR18MB2901: x-microsoft-antispam-prvs: <BYAPR18MB290188240C293E4175EB1C6AC8B60@BYAPR18MB2901.namprd18.prod.outlook.com> x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BYAPR18MB2901; BCL:0; PCL:0; RULEID:; SRVR:BYAPR18MB2901; x-forefront-prvs: 0899B47777 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(199004)(189003)(6506007)(386003)(14444005)(256004)(36756003)(110136005)(6436002)(1076003)(81166006)(54906003)(81156014)(8936002)(2616005)(26005)(97736004)(476003)(99286004)(66066001)(8676002)(486006)(316002)(102836004)(186003)(71200400001)(2906002)(6116002)(3846002)(106356001)(105586002)(4326008)(86362001)(7736002)(5660300001)(14454004)(78486014)(25786009)(305945005)(68736007)(52116002)(6512007)(53936002)(478600001)(71190400001)(107886003)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2901; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jhqESUkdEVRRvA4vYX4gQmfCQZQWCfH0fAjzZzweiPaIX3DIEFBENJBFEgHC0Ws05+G8U8YWY7EE5DFaUGbmKWUwYgqxYM0SC3ImE6VLTZKgZzDXp8/5zBR/xNNIKurk7LRsbGr9nrQfW3T7rjeYPq0kCPZxcBLnBwSss/Ut5kX8sWOI40Mmo/4Oqj3LWqN6LxhKgVgGwLfshAnIWP3WC9W/y6yt7w1V7dRycPMScwTL7HH6mJDd7gN/dTCdDqv9uEX9zJ26rxCzCIB/RoXrCnyqAdXC8GsfLkYvQXnpalnZXFChL/Wo8n2aQu4W3Eh6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 51e59a26-34d2-45c5-68c8-08d66bc17c66 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2018 06:06:48.5754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2901 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-27_04:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812270057 Subject: [dpdk-dev] [PATCH] net/ice: fix build with debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
net/ice: fix build with debug enabled
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
Commit Message
Jerin Jacob Kollanukkaran
Dec. 27, 2018, 6:06 a.m. UTC
When RTE_LIBRTE_MBUF_DEBUG enabled, rte_mbuf_sanity_check()
function defined in rte_mbuf.so library,
add it while linking the librte_pmd_ice.so library to fix
the build issue.
error log:
/usr/bin/ld: ice_rxtx.o: in function `ice_recv_pkts':
ice_rxtx.c:(.text+0x1d97): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: ice_rxtx.o: in function
`ice_tx_queue_release_mbufs':
ice_rxtx.c:(.text+0x21e0): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: ice_rxtx.c:(.text+0x22b3): undefined reference
to `rte_mbuf_sanity_check'
/usr/bin/ld: ice_rxtx.c:(.text+0x24a0): undefined reference
to `rte_mbuf_sanity_check'
/usr/bin/ld: ice_rxtx.c:(.text+0x2640): undefined reference
to `rte_mbuf_sanity_check'
/usr/bin/ld: ice_rxtx.o:ice_rxtx.c:(.text+0x299f):
more undefined references to `rte_mbuf_sanity_check' follow
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
drivers/net/ice/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 12/27/2018 6:06 AM, Jerin Jacob Kollanukkaran wrote: > When RTE_LIBRTE_MBUF_DEBUG enabled, rte_mbuf_sanity_check() > function defined in rte_mbuf.so library, > add it while linking the librte_pmd_ice.so library to fix > the build issue. > > error log: > /usr/bin/ld: ice_rxtx.o: in function `ice_recv_pkts': > ice_rxtx.c:(.text+0x1d97): undefined reference to > `rte_mbuf_sanity_check' > /usr/bin/ld: ice_rxtx.o: in function > `ice_tx_queue_release_mbufs': > ice_rxtx.c:(.text+0x21e0): undefined reference to > `rte_mbuf_sanity_check' > /usr/bin/ld: ice_rxtx.c:(.text+0x22b3): undefined reference > to `rte_mbuf_sanity_check' > /usr/bin/ld: ice_rxtx.c:(.text+0x24a0): undefined reference > to `rte_mbuf_sanity_check' > /usr/bin/ld: ice_rxtx.c:(.text+0x2640): undefined reference > to `rte_mbuf_sanity_check' > /usr/bin/ld: ice_rxtx.o:ice_rxtx.c:(.text+0x299f): > more undefined references to `rte_mbuf_sanity_check' follow > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> Fixes: 50370662b727 ("net/ice: support device and queue ops") Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to dpdk-next-net/master, thanks.
diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index bc244442d..4b421cde3 100644 --- a/drivers/net/ice/Makefile +++ b/drivers/net/ice/Makefile @@ -11,7 +11,8 @@ LIB = librte_pmd_ice.a CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) -LDLIBS += -lrte_eal -lrte_ethdev -lrte_kvargs -lrte_bus_pci -lrte_mempool +LDLIBS += -lrte_eal -lrte_mbuf -lrte_ethdev -lrte_kvargs +LDLIBS += -lrte_bus_pci -lrte_mempool EXPORT_MAP := rte_pmd_ice_version.map