[v2] doc: fix a parameter name in testpmd guide
Checks
Commit Message
There is no parameter called "eth-peer-configfile" in testpmd. It should
be "eth-peers-configfile". See the usage() method in
app/test-pmd/parameters.c.
v2: Fix line too long in the patch commit log.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Friday, January 4, 2019 9:11 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
> Rami Rosen <ramirose@gmail.com>
> Subject: [PATCH v2] doc: fix a parameter name in testpmd guide
>
> There is no parameter called "eth-peer-configfile" in testpmd. It should be "eth-
> peers-configfile". See the usage() method in app/test-pmd/parameters.c.
>
> v2: Fix line too long in the patch commit log.
>
> Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 1/4/2019 9:57 AM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Rami Rosen [mailto:ramirose@gmail.com]
>> Sent: Friday, January 4, 2019 9:11 AM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
>> Rami Rosen <ramirose@gmail.com>
>> Subject: [PATCH v2] doc: fix a parameter name in testpmd guide
>>
>> There is no parameter called "eth-peer-configfile" in testpmd. It should be "eth-
>> peers-configfile". See the usage() method in app/test-pmd/parameters.c.
>>
>> v2: Fix line too long in the patch commit log.
>>
>> Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -304,7 +304,7 @@ The available information categories are:
* ``mac``: Changes the source and the destination Ethernet addresses of packets before forwarding them.
Default application behaviour is to set source Ethernet address to that of the transmitting interface, and destination
address to a dummy value (set during init). The user may specify a target destination Ethernet address via the 'eth-peer' or
- 'eth-peer-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
+ 'eth-peers-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
* ``macswap``: MAC swap forwarding mode.
Swaps the source and the destination Ethernet addresses of packets before forwarding them.