[v2] examples/ip_fragmentation: support big packets

Message ID 1547379358-17310-1-git-send-email-noae@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] examples/ip_fragmentation: support big packets |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Noa Ezra Jan. 13, 2019, 11:37 a.m. UTC
  In some vendors the RX and TX configuration must be the same, therefore
the MTU size need to be equal to max_rx_pkt_len.
The MTU is the largest size packet in bytes that can be sent on the
network, therefore before changing this parameter, the NIC could not
receive packets larger than 1500 bytes, which is the default MTU size.
In addition, scatter-gather need to be enabled in order to receive
frames bigger than mbuf size.

Signed-off-by: Noa Ezra <noae@mellanox.com>
---
v2: move set_mtu() to be done after dev_configure().

 examples/ip_fragmentation/main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
  

Comments

Ananyev, Konstantin Jan. 14, 2019, 12:55 p.m. UTC | #1
> 
> In some vendors the RX and TX configuration must be the same, therefore
> the MTU size need to be equal to max_rx_pkt_len.
> The MTU is the largest size packet in bytes that can be sent on the
> network, therefore before changing this parameter, the NIC could not
> receive packets larger than 1500 bytes, which is the default MTU size.
> In addition, scatter-gather need to be enabled in order to receive
> frames bigger than mbuf size.
> 
> Signed-off-by: Noa Ezra <noae@mellanox.com>
> ---
> v2: move set_mtu() to be done after dev_configure().
> 
>  examples/ip_fragmentation/main.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index 17a877d..8d789b4 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -141,6 +141,7 @@ struct lcore_queue_conf {
>  		.max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
>  		.split_hdr_size = 0,
>  		.offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> +			     DEV_RX_OFFLOAD_SCATTER |
>  			     DEV_RX_OFFLOAD_JUMBO_FRAME),
>  	},
>  	.txmode = {
> @@ -935,6 +936,16 @@ struct rte_lpm6_config lpm6_config = {
>  				ret, portid);
>  		}
> 
> +		/* set the mtu to the maximum received packet size */
> +		ret = rte_eth_dev_set_mtu(portid,
> +			local_port_conf.rxmode.max_rx_pkt_len);
> +		if (ret < 0) {
> +			printf("\n");
> +			rte_exit(EXIT_FAILURE, "Set MTU failed: "
> +				"err=%d, port=%d\n",
> +			ret, portid);
> +		}
> +
>  		ret = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd,
>  					    &nb_txd);
>  		if (ret < 0) {
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 1.8.3.1
  
Thomas Monjalon Jan. 15, 2019, 12:21 a.m. UTC | #2
14/01/2019 13:55, Ananyev, Konstantin:
> > 
> > In some vendors the RX and TX configuration must be the same, therefore
> > the MTU size need to be equal to max_rx_pkt_len.
> > The MTU is the largest size packet in bytes that can be sent on the
> > network, therefore before changing this parameter, the NIC could not
> > receive packets larger than 1500 bytes, which is the default MTU size.
> > In addition, scatter-gather need to be enabled in order to receive
> > frames bigger than mbuf size.
> > 
> > Signed-off-by: Noa Ezra <noae@mellanox.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 17a877d..8d789b4 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -141,6 +141,7 @@  struct lcore_queue_conf {
 		.max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
 		.split_hdr_size = 0,
 		.offloads = (DEV_RX_OFFLOAD_CHECKSUM |
+			     DEV_RX_OFFLOAD_SCATTER |
 			     DEV_RX_OFFLOAD_JUMBO_FRAME),
 	},
 	.txmode = {
@@ -935,6 +936,16 @@  struct rte_lpm6_config lpm6_config = {
 				ret, portid);
 		}
 
+		/* set the mtu to the maximum received packet size */
+		ret = rte_eth_dev_set_mtu(portid,
+			local_port_conf.rxmode.max_rx_pkt_len);
+		if (ret < 0) {
+			printf("\n");
+			rte_exit(EXIT_FAILURE, "Set MTU failed: "
+				"err=%d, port=%d\n",
+			ret, portid);
+		}
+
 		ret = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd,
 					    &nb_txd);
 		if (ret < 0) {