diff mbox series

[DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline

Message ID 1547430067-63007-1-git-send-email-andy.pei@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Pei, Andy Jan. 14, 2019, 1:41 a.m. UTC 
  Original driver requires users to input "afu_bts" args.
After apply this patch, driver can also work without a
"afu_bts" args explicitly in the cmdline.

fixes: 05fa3d4a6539
cc: rosen.xu@intel.com
cc: tianfei.zhang@intel.com
cc: andy.pei@intel.com

Signed-off-by: AndyPei <andy.pei@intel.com>
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Xu, Rosen Jan. 14, 2019, 5:14 a.m. UTC | #1 
> -----Original Message-----
> From: Pei, Andy
> Sent: Monday, January 14, 2019 9:41
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in
> cmdline
> 
> Original driver requires users to input "afu_bts" args.
> After apply this patch, driver can also work without a "afu_bts" args explicitly
> in the cmdline.
> 
> fixes: 05fa3d4a6539
> cc: rosen.xu@intel.com
> cc: tianfei.zhang@intel.com
> cc: andy.pei@intel.com
> 
> Signed-off-by: AndyPei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index 5f23ed8..e4b7b6f 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -125,15 +125,13 @@ void rte_ifpga_driver_unregister(struct
> rte_afu_driver *driver)
>  				     IFPGA_AFU_BTS);
>  			goto end;
>  		}
> +		afu_pr_conf.pr_enable = 1;
>  	} else {
> -		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
> -			  IFPGA_AFU_BTS);
> -		goto end;
> +		afu_pr_conf.pr_enable = 0;
>  	}
> 
>  	afu_pr_conf.afu_id.uuid.uuid_low = 0;
>  	afu_pr_conf.afu_id.uuid.uuid_high = 0;
> -	afu_pr_conf.pr_enable = path?1:0;
> 
>  	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
>  		goto end;
> --
> 1.8.3.1

Acked-by: Rosen Xu <rosen.xu@intel.com>
diff mbox series

Patch

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 5f23ed8..e4b7b6f 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -125,15 +125,13 @@  void rte_ifpga_driver_unregister(struct rte_afu_driver *driver)
 				     IFPGA_AFU_BTS);
 			goto end;
 		}
+		afu_pr_conf.pr_enable = 1;
 	} else {
-		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
-			  IFPGA_AFU_BTS);
-		goto end;
+		afu_pr_conf.pr_enable = 0;
 	}
 
 	afu_pr_conf.afu_id.uuid.uuid_low = 0;
 	afu_pr_conf.afu_id.uuid.uuid_high = 0;
-	afu_pr_conf.pr_enable = path?1:0;
 
 	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
 		goto end;