diff mbox series

config: remove NFP PMD from 32-bits builds

Message ID 20190114181254.27089-1-alejandro.lucero@netronome.com (mailing list archive)
State Accepted, archived
Headers
Series config: remove NFP PMD from 32-bits builds |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Alejandro Lucero Jan. 14, 2019, 6:12 p.m. UTC 
  Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 config/defconfig_i686-native-linuxapp-gcc    | 5 +++++
 config/defconfig_i686-native-linuxapp-icc    | 5 +++++
 config/defconfig_x86_x32-native-linuxapp-gcc | 5 +++++
 3 files changed, 15 insertions(+)

Comments

Thomas Monjalon Jan. 14, 2019, 7:04 p.m. UTC | #1 
14/01/2019 19:12, Alejandro Lucero:
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
>  config/defconfig_i686-native-linuxapp-gcc    | 5 +++++
>  config/defconfig_i686-native-linuxapp-icc    | 5 +++++
>  config/defconfig_x86_x32-native-linuxapp-gcc | 5 +++++
>  3 files changed, 15 insertions(+)

You forgot config/defconfig_arm-armv7a-linuxapp-gcc.

Applied with change for armv7, thanks

PS: It makes me think we have no way to disable some PMDs
for 32-bit with meson. Bruce, any idea?
Bruce Richardson Jan. 15, 2019, 10:39 a.m. UTC | #2 
On Mon, Jan 14, 2019 at 08:04:00PM +0100, Thomas Monjalon wrote:
> 14/01/2019 19:12, Alejandro Lucero:
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> >  config/defconfig_i686-native-linuxapp-gcc    | 5 +++++
> >  config/defconfig_i686-native-linuxapp-icc    | 5 +++++
> >  config/defconfig_x86_x32-native-linuxapp-gcc | 5 +++++
> >  3 files changed, 15 insertions(+)
> 
> You forgot config/defconfig_arm-armv7a-linuxapp-gcc.
> 
> Applied with change for armv7, thanks
> 
> PS: It makes me think we have no way to disable some PMDs
> for 32-bit with meson. Bruce, any idea?
> 
Put something similar to below in the meson.build file for the driver:

if not dpdk_conf.has('RTE_ARCH_64')
	build = false
endif

For drivers which don't already have a condition check you can simplify to:

build = (dpdk_conf.has('RTE_ARCH_64'))

/Bruce
diff mbox series

Patch

diff --git a/config/defconfig_i686-native-linuxapp-gcc b/config/defconfig_i686-native-linuxapp-gcc
index 1178fe35b..9b7086859 100644
--- a/config/defconfig_i686-native-linuxapp-gcc
+++ b/config/defconfig_i686-native-linuxapp-gcc
@@ -47,5 +47,10 @@  CONFIG_RTE_LIBRTE_PMD_ZUC=n
 #
 CONFIG_RTE_LIBRTE_AVP_PMD=n
 
+#
+# NFP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_NFP_PMD=n
+
 # 32-bit doesn't break up memory in lists, but does have VA allocation limit
 CONFIG_RTE_MAX_MEM_MB=2048
diff --git a/config/defconfig_i686-native-linuxapp-icc b/config/defconfig_i686-native-linuxapp-icc
index 016c73f30..17defd803 100644
--- a/config/defconfig_i686-native-linuxapp-icc
+++ b/config/defconfig_i686-native-linuxapp-icc
@@ -47,5 +47,10 @@  CONFIG_RTE_LIBRTE_PMD_ZUC=n
 #
 CONFIG_RTE_LIBRTE_AVP_PMD=n
 
+#
+# NFP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_NFP_PMD=n
+
 # 32-bit doesn't break up memory in lists, but does have VA allocation limit
 CONFIG_RTE_MAX_MEM_MB=2048
diff --git a/config/defconfig_x86_x32-native-linuxapp-gcc b/config/defconfig_x86_x32-native-linuxapp-gcc
index 57d000dc5..2c8419f14 100644
--- a/config/defconfig_x86_x32-native-linuxapp-gcc
+++ b/config/defconfig_x86_x32-native-linuxapp-gcc
@@ -27,5 +27,10 @@  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 #
 CONFIG_RTE_LIBRTE_AVP_PMD=n
 
+#
+# NFP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_NFP_PMD=n
+
 # 32-bit doesn't break up memory in lists, but does have VA allocation limit
 CONFIG_RTE_MAX_MEM_MB=2048