igb_uio: remove out-of-date comment
Checks
Commit Message
The comment for igbuio_pci_irqhandler is out of date as the code evolves,
remove it to avoid misleading.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
kernel/linux/igb_uio/igb_uio.c | 5 -----
1 file changed, 5 deletions(-)
Comments
On 15-Jan-19 3:46 PM, Xiaolong Ye wrote:
> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
> remove it to avoid misleading.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> kernel/linux/igb_uio/igb_uio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
> index 3cf394bdf..7e69b4498 100644
> --- a/kernel/linux/igb_uio/igb_uio.c
> +++ b/kernel/linux/igb_uio/igb_uio.c
> @@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
> return 0;
> }
>
> -/**
> - * This is interrupt handler which will check if the interrupt is for the right device.
> - * If yes, disable it here and will be enable later.
> - */
> -static irqreturn_t
> igbuio_pci_irqhandler(int irq, void *dev_id)
> {
> struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;
>
I think you removed one extra line there...
On 01/15, Burakov, Anatoly wrote:
>On 15-Jan-19 3:46 PM, Xiaolong Ye wrote:
>> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
>> remove it to avoid misleading.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> kernel/linux/igb_uio/igb_uio.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
>> index 3cf394bdf..7e69b4498 100644
>> --- a/kernel/linux/igb_uio/igb_uio.c
>> +++ b/kernel/linux/igb_uio/igb_uio.c
>> @@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
>> return 0;
>> }
>> -/**
>> - * This is interrupt handler which will check if the interrupt is for the right device.
>> - * If yes, disable it here and will be enable later.
>> - */
>> -static irqreturn_t
>> igbuio_pci_irqhandler(int irq, void *dev_id)
>> {
>> struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;
>>
>
>I think you removed one extra line there...
oops, thanks for the catch, I'll send a v2.
Thanks,
Xiaolong
>
>--
>Thanks,
>Anatoly
@@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
return 0;
}
-/**
- * This is interrupt handler which will check if the interrupt is for the right device.
- * If yes, disable it here and will be enable later.
- */
-static irqreturn_t
igbuio_pci_irqhandler(int irq, void *dev_id)
{
struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;