diff mbox series

net/tap: fix multi process request

Message ID 1551174642-14048-1-git-send-email-rasland@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/tap: fix multi process request |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Raslan Darawsheh Feb. 26, 2019, 9:50 a.m. UTC 
  The structure was not initialized.

Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/tap/rte_eth_tap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rami Rosen Feb. 26, 2019, 10:13 a.m. UTC | #1 
Reviewed-by: Rami Rosen <ramirose at gmail.com>


On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh <rasland@mellanox.com>
wrote:

> The structure was not initialized.
>
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
> secondary")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 586c8a9..6f5109f 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -2086,6 +2086,7 @@ tap_mp_attach_queues(const char *port_name, struct
> rte_eth_dev *dev)
>         int queue, fd_iterator;
>
>         /* Prepare the request */
> +       memset(&request, 0, sizeof(request));
>         strlcpy(request.name, TAP_MP_KEY, sizeof(request.name));
>         strlcpy(request_param->port_name, port_name,
>                 sizeof(request_param->port_name));
> --
> 2.7.4
>
>
Ferruh Yigit Feb. 26, 2019, 10:57 a.m. UTC | #2 
On 2/26/2019 10:13 AM, Rami Rosen wrote:
> Reviewed-by: Rami Rosen <ramirose at gmail.com>
> 
> 
> On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> 
>> The structure was not initialized.
>>
>> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
>> secondary")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 586c8a9..6f5109f 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2086,6 +2086,7 @@  tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
 	int queue, fd_iterator;
 
 	/* Prepare the request */
+	memset(&request, 0, sizeof(request));
 	strlcpy(request.name, TAP_MP_KEY, sizeof(request.name));
 	strlcpy(request_param->port_name, port_name,
 		sizeof(request_param->port_name));