diff mbox series

[v1,07/11] mk: add link enablement for IPN3KE

Message ID 1551338000-120348-8-git-send-email-rosen.xu@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series Add patch set for IPN3KE |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Xu, Rosen Feb. 28, 2019, 7:13 a.m. UTC 
  Add link enablement for Intel FPGA Acceleration
NIC IPN3KE.

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 mk/rte.app.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit March 6, 2019, 12:45 p.m. UTC | #1 
On 2/28/2019 7:13 AM, Rosen Xu wrote:
> Add link enablement for Intel FPGA Acceleration
> NIC IPN3KE.

Again, I think no need/benefit to make this separate patch, please merge into
main one that add pmd.

> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
>  mk/rte.app.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 8a4f0f4..8b427d1 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -295,6 +295,7 @@ endif # CONFIG_RTE_LIBRTE_FSLMC_BUS
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
>  ifeq ($(CONFIG_RTE_LIBRTE_IFPGA_BUS),y)
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV)   += -lrte_pmd_ifpga_rawdev
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_IPN3KE_PMD)       += -lrte_pmd_ipn3ke
>  endif # CONFIG_RTE_LIBRTE_IFPGA_BUS
>  endif # CONFIG_RTE_LIBRTE_RAWDEV
>  
>
Xu, Rosen March 8, 2019, 12:56 a.m. UTC | #2 
> -----Original Message-----
> From: Yigit, Ferruh [mailto:ferruh.yigit@linux.intel.com]
> Sent: Wednesday, March 06, 2019 20:46
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy
> <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 07/11] mk: add link enablement for
> IPN3KE
> 
> On 2/28/2019 7:13 AM, Rosen Xu wrote:
> > Add link enablement for Intel FPGA Acceleration NIC IPN3KE.
> 
> Again, I think no need/benefit to make this separate patch, please merge
> into main one that add pmd.

Okay  

> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  mk/rte.app.mk | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 8a4f0f4..8b427d1
> > 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -295,6 +295,7 @@ endif # CONFIG_RTE_LIBRTE_FSLMC_BUS
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
> >  ifeq ($(CONFIG_RTE_LIBRTE_IFPGA_BUS),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV)   += -
> lrte_pmd_ifpga_rawdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IPN3KE_PMD)       += -lrte_pmd_ipn3ke
> >  endif # CONFIG_RTE_LIBRTE_IFPGA_BUS
> >  endif # CONFIG_RTE_LIBRTE_RAWDEV
> >
> >
diff mbox series

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 8a4f0f4..8b427d1 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -295,6 +295,7 @@  endif # CONFIG_RTE_LIBRTE_FSLMC_BUS
 _LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
 ifeq ($(CONFIG_RTE_LIBRTE_IFPGA_BUS),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV)   += -lrte_pmd_ifpga_rawdev
+_LDLIBS-$(CONFIG_RTE_LIBRTE_IPN3KE_PMD)       += -lrte_pmd_ipn3ke
 endif # CONFIG_RTE_LIBRTE_IFPGA_BUS
 endif # CONFIG_RTE_LIBRTE_RAWDEV