[v3,2/2] devtools: fix result of svg include check
Checks
Commit Message
Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.
Signed-off-by: Michael Santana <msantana@redhat.com>
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
01/03/2019 18:08, Michael Santana:
> Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> as a command, rather than a simple variable assignment.
>
> Signed-off-by: Michael Santana <msantana@redhat.com>
> Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
CC: stable@dpdk.org must be inserted below Fixes for the record in git.
Note also that Signed-off-by must be below with a blank line.
On Fri, Mar 1, 2019 at 6:52 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 01/03/2019 18:08, Michael Santana:
> > Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> > as a command, rather than a simple variable assignment.
> >
> > Signed-off-by: Michael Santana <msantana@redhat.com>
> > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
>
> CC: stable@dpdk.org must be inserted below Fixes for the record in git.
>
> Note also that Signed-off-by must be below with a blank line.
>
Ah ah, great that we won't have to check this manually soon :-)
Reviewed-by: David Marchand <david.marchand@redhat.com>
@@ -73,7 +73,7 @@ check_forbidden_additions() { # <patch>
-v RET_ON_FAIL=1 \
-v MESSAGE='Using explicit .svg extension instead of .*' \
-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
- "$1" || res = 1
+ "$1" || res=1
return $res
}