diff mbox series

devtools: fix incorrect shell assignment

Message ID 1551693445-23533-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: fix incorrect shell assignment |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand March 4, 2019, 9:57 a.m. UTC 
  No space needed here:
./devtools/checkpatches.sh: line 65: res: command not found

Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon March 4, 2019, 10:12 a.m. UTC | #1 
04/03/2019 10:57, David Marchand:
> No space needed here:
> ./devtools/checkpatches.sh: line 65: res: command not found
> 
> Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> Cc: stable@dpdk.org
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Thank you
It is already submitted:
	https://patches.dpdk.org/patch/50727/
It is part of a patchset, waiting for a new version (for codespell feature).
David Marchand March 4, 2019, 10:17 a.m. UTC | #2 
On Mon, Mar 4, 2019 at 11:13 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 04/03/2019 10:57, David Marchand:
> > No space needed here:
> > ./devtools/checkpatches.sh: line 65: res: command not found
> >
> > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> > Cc: stable@dpdk.org
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Thank you
> It is already submitted:
>         https://patches.dpdk.org/patch/50727/
> It is part of a patchset, waiting for a new version (for codespell
> feature).
>

Indeed, thanks.
diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 3b03b7e..02d1c30 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -62,7 +62,7 @@  check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1" || res = 1
+		"$1" || res=1
 
 	return $res
 }