meson: remove build warnings
Checks
Commit Message
From: Jerin Jacob <jerinj@marvell.com>
Remove the following meson build warnings
1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
but uses features which were added in newer versions:
* 0.48.0: {'console arg in custom_target'}
2) config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
config/arm/meson.build | 4 ++--
meson.build | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following meson build warnings
>
> 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> but uses features which were added in newer versions:
> * 0.48.0: {'console arg in custom_target'}
>
> 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> config/arm/meson.build | 4 ++--
> meson.build | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
> diff --git a/meson.build b/meson.build
> index 69833de82..f1abf1e59 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -5,7 +5,7 @@ project('DPDK', 'C',
> version: '19.05.0-rc0',
> license: 'BSD',
> default_options: ['buildtype=release',
> 'default_library=static'],
> - meson_version: '>= 0.47.1'
> + meson_version: '>= 0.48.0'
> )
>
> # set up some global vars for compiler, platform, configuration,
> etc.
Bumping minimum dependency requirements needs an approval from the tech
board. Incidentally we just got it, and the bump to 0.47.1 just
happened.
You can remove this and ignore the warning about the console arg - it's
harmless if ran on a previous version which does not support it.
On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following meson build warnings
> >
> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> > but uses features which were added in newer versions:
> > * 0.48.0: {'console arg in custom_target'}
> >
> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > config/arm/meson.build | 4 ++--
> > meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index 8e892fa77..170a4981a 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -116,8 +116,8 @@ else
> > cmd_output =
> > cmd.stdout().to_lower().strip().split(' ')
> > endif
> > # Set to generic if variable is not found
> > - machine = get_variable('impl_' + cmd_output[0],
> > 'generic')
> > - if machine == 'generic'
> > + machine = get_variable('impl_' + cmd_output[0],
> > ['generic'])
> > + if machine[0] == 'generic'
> > machine = impl_generic
> > cmd_output = cmd_generic
> > endif
> > diff --git a/meson.build b/meson.build
> > index 69833de82..f1abf1e59 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > version: '19.05.0-rc0',
> > license: 'BSD',
> > default_options: ['buildtype=release',
> > 'default_library=static'],
> > - meson_version: '>= 0.47.1'
> > + meson_version: '>= 0.48.0'
> > )
> >
> > # set up some global vars for compiler, platform, configuration,
> > etc.
>
> Bumping minimum dependency requirements needs an approval from the tech
> board. Incidentally we just got it, and the bump to 0.47.1 just
> happened.
>
> You can remove this and ignore the warning about the console arg - it's
> harmless if ran on a previous version which does not support it.
>
+1 to this. The first fix is good though - perhaps do a V2 with just that.
Sadly meson warnings for versions have too many false positives right now -
the devs are aware of it, but don't have any good fixes for it yet, as far
as I know. For our case, we will continue to have meson warnings, most of
which are false positives like this one.
Regards,
/Bruce
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
>> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
>> > From: Jerin Jacob <jerinj@marvell.com>
>> >
>> > Remove the following meson build warnings
>> >
>> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
>> > but uses features which were added in newer versions:
>> > * 0.48.0: {'console arg in custom_target'}
>> >
>> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
>> > different types (list, str) using ==.
>> >
>> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> > ---
>> > config/arm/meson.build | 4 ++--
>> > meson.build | 2 +-
>> > 2 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/config/arm/meson.build b/config/arm/meson.build
>> > index 8e892fa77..170a4981a 100644
>> > --- a/config/arm/meson.build
>> > +++ b/config/arm/meson.build
>> > @@ -116,8 +116,8 @@ else
>> > cmd_output =
>> > cmd.stdout().to_lower().strip().split(' ')
>> > endif
>> > # Set to generic if variable is not found
>> > - machine = get_variable('impl_' + cmd_output[0],
>> > 'generic')
>> > - if machine == 'generic'
>> > + machine = get_variable('impl_' + cmd_output[0],
>> > ['generic'])
>> > + if machine[0] == 'generic'
>> > machine = impl_generic
>> > cmd_output = cmd_generic
>> > endif
>> > diff --git a/meson.build b/meson.build
>> > index 69833de82..f1abf1e59 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
>> > version: '19.05.0-rc0',
>> > license: 'BSD',
>> > default_options: ['buildtype=release',
>> > 'default_library=static'],
>> > - meson_version: '>= 0.47.1'
>> > + meson_version: '>= 0.48.0'
>> > )
>> >
>> > # set up some global vars for compiler, platform, configuration,
>> > etc.
>>
>> Bumping minimum dependency requirements needs an approval from the tech
>> board. Incidentally we just got it, and the bump to 0.47.1 just
>> happened.
>>
>> You can remove this and ignore the warning about the console arg - it's
>> harmless if ran on a previous version which does not support it.
>>
>
> +1 to this. The first fix is good though - perhaps do a V2 with just that.
>
> Sadly meson warnings for versions have too many false positives right now -
> the devs are aware of it, but don't have any good fixes for it yet, as far
> as I know. For our case, we will continue to have meson warnings, most of
> which are false positives like this one.
In this case, though, the warning isn't a false positive. Here are the
release notes for 0.48.0 that relate to the argument in question:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
I probably missed something.
<rant>
Incidentally, I've dropped my own patch related to this from a series I
was developing to run tests on travis. I think it's a bit annoying that
we need the techboard to decide for cases like these, but I guess that's
just a fact of life.
</rant>
> Regards,
> /Bruce
On Wed, 2019-03-27 at 11:28 -0400, Aaron Conole wrote:
> Bruce Richardson <
> bruce.richardson@intel.com
> > writes:
>
> > On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> > > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran
> > > wrote:
> > > > From: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > >
> > > > Remove the following meson build warnings
> > > >
> > > > 1) WARNING: Project specifies a minimum meson_version '>=
> > > > 0.47.1'
> > > > but uses features which were added in newer versions:
> > > > * 0.48.0: {'console arg in custom_target'}
> > > >
> > > > 2) config/arm/meson.build:153: WARNING: Trying to compare
> > > > values of
> > > > different types (list, str) using ==.
> > > >
> > > > Signed-off-by: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > > ---
> > > > config/arm/meson.build | 4 ++--
> > > > meson.build | 2 +-
> > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > > > index 8e892fa77..170a4981a 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -116,8 +116,8 @@ else
> > > > cmd_output =
> > > > cmd.stdout().to_lower().strip().split(' ')
> > > > endif
> > > > # Set to generic if variable is not found
> > > > - machine = get_variable('impl_' + cmd_output[0],
> > > > 'generic')
> > > > - if machine == 'generic'
> > > > + machine = get_variable('impl_' + cmd_output[0],
> > > > ['generic'])
> > > > + if machine[0] == 'generic'
> > > > machine = impl_generic
> > > > cmd_output = cmd_generic
> > > > endif
> > > > diff --git a/meson.build b/meson.build
> > > > index 69833de82..f1abf1e59 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > > > version: '19.05.0-rc0',
> > > > license: 'BSD',
> > > > default_options: ['buildtype=release',
> > > > 'default_library=static'],
> > > > - meson_version: '>= 0.47.1'
> > > > + meson_version: '>= 0.48.0'
> > > > )
> > > >
> > > > # set up some global vars for compiler, platform,
> > > > configuration,
> > > > etc.
> > >
> > > Bumping minimum dependency requirements needs an approval from
> > > the tech
> > > board. Incidentally we just got it, and the bump to 0.47.1 just
> > > happened.
> > >
> > > You can remove this and ignore the warning about the console arg
> > > - it's
> > > harmless if ran on a previous version which does not support it.
> > >
> >
> > +1 to this. The first fix is good though - perhaps do a V2 with
> > just that.
> >
> > Sadly meson warnings for versions have too many false positives
> > right now -
> > the devs are aware of it, but don't have any good fixes for it yet,
> > as far
> > as I know. For our case, we will continue to have meson warnings,
> > most of
> > which are false positives like this one.
>
> In this case, though, the warning isn't a false positive. Here are
> the
> release notes for 0.48.0 that relate to the argument in question:
>
> https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
>
>
> I probably missed something.
>
> <rant>
> Incidentally, I've dropped my own patch related to this from a series
> I
> was developing to run tests on travis. I think it's a bit annoying
> that
> we need the techboard to decide for cases like these, but I guess
> that's
> just a fact of life.
> </rant>
The warning is correct, but it is harmless - simply the feature won't
be available - I forget exactly what is was for, something to do with
verbose console prints. Functionally speaking there's no difference.
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
@@ -5,7 +5,7 @@ project('DPDK', 'C',
version: '19.05.0-rc0',
license: 'BSD',
default_options: ['buildtype=release', 'default_library=static'],
- meson_version: '>= 0.47.1'
+ meson_version: '>= 0.48.0'
)
# set up some global vars for compiler, platform, configuration, etc.