[v4] service: fix parameter type
Checks
Commit Message
The type of value parameter to rte_service_attr_get
should be uint64_t *, since the attributes
are of type uint64_t.
Fixes: 4d55194d76a4 ("service: add attribute get function")
Reviewed-by: Gage Eads <gage.eads@intel.com>
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
---
lib/librte_eal/common/include/rte_service.h | 2 +-
app/test/test_service_cores.c | 2 +-
lib/librte_eal/common/rte_service.c | 2 +-
doc/guides/rel_notes/deprecation.rst | 4 ----
doc/guides/rel_notes/release_19_05.rst | 5 ++++-
lib/librte_eal/bsdapp/eal/Makefile | 2 +-
lib/librte_eal/linuxapp/eal/Makefile | 2 +-
lib/librte_eal/meson.build | 2 +-
8 files changed, 10 insertions(+), 11 deletions(-)
v2:
* Update release notes.
* Update library version in makefiles.
v3:
* Remove deprecation notice.
v4:
* Update path for test_service_cores.c.
* Fix whitespace in release_19_05.rst.
Comments
28/03/2019 07:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
Rebased for master and applied, thanks.
@@ -372,7 +372,7 @@ int32_t rte_service_run_iter_on_app_lcore(uint32_t id,
* -EINVAL Invalid id, attr_id or attr_value was NULL.
*/
int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
- uint32_t *attr_value);
+ uint64_t *attr_value);
/**
* Reset all attribute values of a service.
@@ -259,7 +259,7 @@ static int32_t dummy_mt_safe_cb(void *args)
rte_service_set_stats_enable(id, 1);
uint32_t attr_id = UINT32_MAX;
- uint32_t attr_value = 0xdead;
+ uint64_t attr_value = 0xdead;
/* check error return values */
TEST_ASSERT_EQUAL(-EINVAL, rte_service_attr_get(id, attr_id,
&attr_value),
@@ -734,7 +734,7 @@ int32_t rte_service_run_iter_on_app_lcore(uint32_t id,
}
int32_t
-rte_service_attr_get(uint32_t id, uint32_t attr_id, uint32_t *attr_value)
+rte_service_attr_get(uint32_t id, uint32_t attr_id, uint64_t *attr_value)
{
struct rte_service_spec_impl *s;
SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
@@ -20,10 +20,6 @@ Deprecation Notices
* kvargs: The function ``rte_kvargs_process`` will get a new parameter
for returning key match count. It will ease handling of no-match case.
-* eal: The ``attr_value`` parameter of ``rte_service_attr_get()``
- will be changed from ``uint32_t *`` to ``uint64_t *``
- as the attributes are of type ``uint64_t``.
-
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
@@ -106,6 +106,9 @@ API Changes
Also, make sure to start the actual text at the margin.
=========================================================
+eal: as shown in the 19.02 deprecation notice, the type of the ``attr_value``
+ parameter of the function ``rte_service_attr_get()`` has been changed
+ from ``uint32_t *`` to ``uint64_t *``.
ABI Changes
-----------
@@ -155,7 +158,7 @@ The libraries prepended with a plus sign were incremented in this version.
librte_compressdev.so.1
librte_cryptodev.so.6
librte_distributor.so.1
- librte_eal.so.9
+ + librte_eal.so.10
librte_efd.so.1
librte_ethdev.so.11
librte_eventdev.so.6
@@ -22,7 +22,7 @@ LDLIBS += -lrte_kvargs
EXPORT_MAP := ../../rte_eal_version.map
-LIBABIVER := 9
+LIBABIVER := 10
# specific to bsdapp exec-env
SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) := eal.c
@@ -10,7 +10,7 @@ ARCH_DIR ?= $(RTE_ARCH)
EXPORT_MAP := ../../rte_eal_version.map
VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)
-LIBABIVER := 9
+LIBABIVER := 10
VPATH += $(RTE_SDK)/lib/librte_eal/common
@@ -21,7 +21,7 @@ else
error('unsupported system type "@0@"'.format(host_machine.system()))
endif
-version = 9 # the version of the EAL API
+version = 10 # the version of the EAL API
allow_experimental_apis = true
deps += 'kvargs'
if dpdk_conf.has('RTE_USE_LIBBSD')