[v3,1/1] compress/isal: fix compression stream initialization

Message ID 1553763987-24263-2-git-send-email-tomaszx.cel@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series This patch fix compression stream initialization |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing fail Performance Testing issues
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Cel, TomaszX March 28, 2019, 9:06 a.m. UTC
  This patch fixes ISAL internal state fields initialization.

Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Cc: stable@dpdk.org

Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
 drivers/compress/isal/isal_compress_pmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
  

Comments

Fiona Trahe March 28, 2019, 12:58 p.m. UTC | #1
> -----Original Message-----
> From: Cel, TomaszX
> Sent: Thursday, March 28, 2019 9:06 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee <lee.daly@intel.com>; Tucker,
> Greg B <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
> <tomaszx.cel@intel.com>
> Subject: [PATCH v3 1/1] compress/isal: fix compression stream initialization
> 
> This patch fixes ISAL internal state fields initialization.
> 
> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  
Daly, Lee March 28, 2019, 1:23 p.m. UTC | #2
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, March 28, 2019 12:59 PM
> To: Cel, TomaszX <tomaszx.cel@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Daly, Lee <lee.daly@intel.com>; Tucker, Greg B
> <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream
> initialization
> 
> 
> 
> > -----Original Message-----
> > From: Cel, TomaszX
> > Sent: Thursday, March 28, 2019 9:06 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
> > <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>;
> > Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
> > <tomaszx.cel@intel.com>
> > Subject: [PATCH v3 1/1] compress/isal: fix compression stream
> > initialization
> >
> > This patch fixes ISAL internal state fields initialization.
> >
> > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression
> > functionality")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Lee Daly <lee.daly@intel.com>
  
Akhil Goyal March 29, 2019, 2:20 p.m. UTC | #3
On 3/28/2019 6:53 PM, Daly, Lee wrote:
>
>> -----Original Message-----
>> From: Trahe, Fiona
>> Sent: Thursday, March 28, 2019 12:59 PM
>> To: Cel, TomaszX <tomaszx.cel@intel.com>; dev@dpdk.org
>> Cc: stable@dpdk.org; Daly, Lee <lee.daly@intel.com>; Tucker, Greg B
>> <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
>> Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream
>> initialization
>>
>>
>>
>>> -----Original Message-----
>>> From: Cel, TomaszX
>>> Sent: Thursday, March 28, 2019 9:06 AM
>>> To: dev@dpdk.org
>>> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
>>> <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>;
>>> Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
>>> <tomaszx.cel@intel.com>
>>> Subject: [PATCH v3 1/1] compress/isal: fix compression stream
>>> initialization
>>>
>>> This patch fixes ISAL internal state fields initialization.
>>>
>>> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression
>>> functionality")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
>> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Lee Daly <lee.daly@intel.com>
Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 8879a42..ca1d703 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -412,7 +412,7 @@  process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	uint8_t *temp_level_buf = qp->stream->level_buf;
 
 	/* Initialize compression stream */
-	isal_deflate_stateless_init(qp->stream);
+	isal_deflate_init(qp->stream);
 
 	qp->stream->level_buf = temp_level_buf;
 
@@ -514,8 +514,6 @@  process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 		op->output_chksum = qp->stream->internal_state.crc;
 	}
 
-	isal_deflate_reset(qp->stream);
-
 	return ret;
 }
 
@@ -598,8 +596,6 @@  process_isal_inflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	op->produced = qp->state->total_out;
 	op->output_chksum = qp->state->crc;
 
-	isal_inflate_reset(qp->state);
-
 	return ret;
 }