diff mbox series

net/ena: fix assigning Rx csum support to Tx flag

Message ID 20190408102744.2942-1-mk@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/ena: fix assigning Rx csum support to Tx flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Michal Krawczyk April 8, 2019, 10:27 a.m. UTC 
  The boolean value was assigned to Tx flag twice, so it could cause bug
whenever Rx checksum will not be supported and Tx will be.

It was detected by the coverity scan, with CID 336831.

Fixes: 117ba4a60488 ("net/ena: get device info statically")
Cc: stable@dpdk.org

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
---
 drivers/net/ena/ena_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit April 8, 2019, 1:49 p.m. UTC | #1 
On 4/8/2019 11:27 AM, Michal Krawczyk wrote:
> The boolean value was assigned to Tx flag twice, so it could cause bug
> whenever Rx checksum will not be supported and Tx will be.
> 
> It was detected by the coverity scan, with CID 336831.
> 
> Fixes: 117ba4a60488 ("net/ena: get device info statically")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>

    Coverity issue: 336831
    Fixes: 117ba4a60488 ("net/ena: get device info statically")

(No "Cc: stable@dpdk.org" required since the issue has been introduced in this
release)


Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index a55b4a719..3eb38165c 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1808,7 +1808,7 @@  static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
 		ENA_ADMIN_FEATURE_OFFLOAD_DESC_TSO_IPV4_MASK) != 0;
 	adapter->offloads.tx_csum_supported = (get_feat_ctx.offload.tx &
 		ENA_ADMIN_FEATURE_OFFLOAD_DESC_TX_L4_IPV4_CSUM_PART_MASK) != 0;
-	adapter->offloads.tx_csum_supported =
+	adapter->offloads.rx_csum_supported =
 		(get_feat_ctx.offload.rx_supported &
 		ENA_ADMIN_FEATURE_OFFLOAD_DESC_RX_L4_IPV4_CSUM_MASK) != 0;