[v1] examples/power: fix vm power manager resource leak

Message ID 20190409094326.9011-1-david.hunt@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] examples/power: fix vm power manager resource leak |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Hunt, David April 9, 2019, 9:43 a.m. UTC
  Fixes: 99a968fac0cf ("examples/vm_power: add core list parameter")
    Coverity issue: 337674

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/vm_power_manager/main.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Pattan, Reshma April 18, 2019, 2:55 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Tuesday, April 9, 2019 10:43 AM
> To: dev@dpdk.org
> Cc: Hunt, David <david.hunt@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] examples/power: fix vm power manager
> resource leak
> 
> Fixes: 99a968fac0cf ("examples/vm_power: add core list parameter")
>     Coverity issue: 337674
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

is it a candidate for stable@dpdk.org?  

Other than that 

Acked-by: Reshma Pattan <reshma.pattan@intel.com>
  
Thomas Monjalon April 22, 2019, 8:57 p.m. UTC | #2
09/04/2019 11:43, David Hunt:
> Fixes: 99a968fac0cf ("examples/vm_power: add core list parameter")
>     Coverity issue: 337674
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
index 893bf4cdd..dd79a82fa 100644
--- a/examples/vm_power_manager/main.c
+++ b/examples/vm_power_manager/main.c
@@ -175,6 +175,7 @@  parse_args(int argc, char **argv)
 			if (cnt < 0) {
 				printf("Invalid core-list - [%s]\n",
 						optarg);
+				free(oob_enable);
 				break;
 			}
 			for (i = 0; i < ci->core_count; i++) {