diff mbox series

[v2,7/8] ipc: fix net/mlx4 memleak

Message ID	20190423174334.19612-8-herakliusz.lipiec@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Herakliusz Lipiec <herakliusz.lipiec@intel.com> To: Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com> Cc: dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>, yskoh@mellanox.com Date: Tue, 23 Apr 2019 18:43:33 +0100 Message-Id: <20190423174334.19612-8-herakliusz.lipiec@intel.com> In-Reply-To: <20190423174334.19612-1-herakliusz.lipiec@intel.com> References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> <20190423174334.19612-1-herakliusz.lipiec@intel.com> Subject: [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	ipc: fix possible memleaks \| [v2,0/8] ipc: fix possible memleaks [v2,1/8] ipc: fix rte_mp_request_sync memleak [v2,2/8] ipc: fix hotplug memleak [v2,3/8] ipc: fix vdev memleak [v2,4/8] ipc: fix vfio memleak [v2,5/8] ipc: fix pdump memleak [v2,6/8] ipc: fix tap pmd memleak [v2,7/8] ipc: fix net/mlx4 memleak [v2,8/8] ipc: fix net/mlx5 memleak

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Herakliusz Lipiec April 23, 2019, 5:43 p.m. UTC

  When sending synchronous IPC requests, the caller must free the response 
buffer even if the request returned failure. Fix the code to correctly 
use the IPC API.

Bugzilla ID:228
Fixes: 0b259b8e9655 ("net/mlx4: enable secondary process to register DMA memory")
Cc: yskoh@mellanox.com
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
 drivers/net/mlx4/mlx4_mp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Yongseok Koh April 23, 2019, 8:16 p.m. UTC | #1

> On Apr 23, 2019, at 10:43 AM, Herakliusz Lipiec <herakliusz.lipiec@intel.com> wrote:
> 
> When sending synchronous IPC requests, the caller must free the response 
> buffer even if the request returned failure. Fix the code to correctly 
> use the IPC API.
> 
> Bugzilla ID:228
> Fixes: 0b259b8e9655 ("net/mlx4: enable secondary process to register DMA memory")
> Cc: yskoh@mellanox.com
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>

> drivers/net/mlx4/mlx4_mp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c
> index 183622453..f4cff7486 100644
> --- a/drivers/net/mlx4/mlx4_mp.c
> +++ b/drivers/net/mlx4/mlx4_mp.c
> @@ -255,6 +255,7 @@ mlx4_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)
> 	if (ret) {
> 		ERROR("port %u request to primary process failed",
> 		      dev->data->port_id);
> +		free(mp_rep.msgs);
> 		return -rte_errno;
> 	}
> 	assert(mp_rep.nb_received == 1);
> @@ -292,7 +293,8 @@ mlx4_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)
> 	if (ret) {
> 		ERROR("port %u request to primary process failed",
> 		      dev->data->port_id);
> -		return -rte_errno;
> +		ret = -rte_errno;
> +		goto exit;
> 	}
> 	assert(mp_rep.nb_received == 1);
> 	mp_res = &mp_rep.msgs[0];
> -- 
> 2.17.2
>

diff mbox series

Patch

diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c
index 183622453..f4cff7486 100644
--- a/drivers/net/mlx4/mlx4_mp.c
+++ b/drivers/net/mlx4/mlx4_mp.c
@@ -255,6 +255,7 @@  mlx4_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)
 	if (ret) {
 		ERROR("port %u request to primary process failed",
 		      dev->data->port_id);
+		free(mp_rep.msgs);
 		return -rte_errno;
 	}
 	assert(mp_rep.nb_received == 1);
@@ -292,7 +293,8 @@  mlx4_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)
 	if (ret) {
 		ERROR("port %u request to primary process failed",
 		      dev->data->port_id);
-		return -rte_errno;
+		ret = -rte_errno;
+		goto exit;
 	}
 	assert(mp_rep.nb_received == 1);
 	mp_res = &mp_rep.msgs[0];