net/vmxnet3: add VLAN filter capability

Message ID 20190501152942.6552-1-mgillott@vyatta.att-mail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/vmxnet3: add VLAN filter capability |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Mark Gillott May 1, 2019, 3:29 p.m. UTC
  The driver supports VLAN filtering, but the option is not included in
the advertised list of capabilities. Thus any attempt to enable VLAN
filtering always fails. Update the list of offload capabilities to
include DEV_RX_OFFLOAD_VLAN_FILTER.

Signed-off-by: Mark Gillott <mgillott@vyatta.att-mail.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Yong Wang May 1, 2019, 6:02 p.m. UTC | #1
-----Original Message-----
From: Mark Gillott <mgillott@vyatta.att-mail.com>
Date: Wednesday, May 1, 2019 at 8:30 AM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Mark Gillott <mgillott@vyatta.att-mail.com>
Subject: [PATCH] net/vmxnet3: add VLAN filter capability

    The driver supports VLAN filtering, but the option is not included in
    the advertised list of capabilities. Thus any attempt to enable VLAN
    filtering always fails. Update the list of offload capabilities to
    include DEV_RX_OFFLOAD_VLAN_FILTER.
    
    Signed-off-by: Mark Gillott <mgillott@vyatta.att-mail.com>
    ---
Acked-by: Yong Wang <yongwang@vmware.com>

     drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 846d7fd7a..f54536b49 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -52,6 +52,7 @@
     
     #define VMXNET3_RX_OFFLOAD_CAP		\
     	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
    +	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
     	 DEV_RX_OFFLOAD_SCATTER |	\
     	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
     	 DEV_RX_OFFLOAD_UDP_CKSUM |	\
    -- 
    2.17.1
  
Ferruh Yigit May 2, 2019, 4:43 p.m. UTC | #2
On 5/1/2019 7:02 PM, Yong Wang wrote:
> -----Original Message-----
> From: Mark Gillott <mgillott@vyatta.att-mail.com>
> Date: Wednesday, May 1, 2019 at 8:30 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>, Mark Gillott <mgillott@vyatta.att-mail.com>
> Subject: [PATCH] net/vmxnet3: add VLAN filter capability
> 
>     The driver supports VLAN filtering, but the option is not included in
>     the advertised list of capabilities. Thus any attempt to enable VLAN
>     filtering always fails. Update the list of offload capabilities to
>     include DEV_RX_OFFLOAD_VLAN_FILTER.
>     
>     Signed-off-by: Mark Gillott <mgillott@vyatta.att-mail.com>
>     ---
> Acked-by: Yong Wang <yongwang@vmware.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 846d7fd7a..f54536b49 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -52,6 +52,7 @@ 
 
 #define VMXNET3_RX_OFFLOAD_CAP		\
 	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
+	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
 	 DEV_RX_OFFLOAD_SCATTER |	\
 	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
 	 DEV_RX_OFFLOAD_UDP_CKSUM |	\