| Message ID | 1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 735145920; Thu, 16 May 2019 09:10:46 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10120.outbound.protection.outlook.com [40.107.1.120]) by dpdk.org (Postfix) with ESMTP id DBB1958EC; Thu, 16 May 2019 09:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cgstowernetworks.onmicrosoft.com; s=selector1-cgstowernetworks-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiH63VZTLl52Oy/I+i4yEmu99lE/oxUIDVvo16HGy74=; b=ugg8X28efip80AUpvigFSp5UlQPUuK+UNvrCD1jFo9Wm7xPwUNEnzu9lgAvmUp6N+ZNIAgpgR9Cbg2w4oJT2NlLW2LBlntPOMbrqj9o7yyHu22RAHzUmiytiv7C0q/U7ZvOEvKEBAeT05avREvBoqOhUOQGfXJ1pvD6aGxxOyQ8= Received: from DB6PR0902MB1829.eurprd09.prod.outlook.com (10.171.77.8) by DB6PR0902MB2198.eurprd09.prod.outlook.com (10.170.213.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Thu, 16 May 2019 07:10:38 +0000 Received: from DB6PR0902MB1829.eurprd09.prod.outlook.com ([fe80::17a:9c16:53df:a0ca]) by DB6PR0902MB1829.eurprd09.prod.outlook.com ([fe80::17a:9c16:53df:a0ca%3]) with mapi id 15.20.1878.024; Thu, 16 May 2019 07:10:38 +0000 From: Yogev Chaimovich <yogev@cgstowernetworks.com> To: "yongwang@vmware.com" <yongwang@vmware.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH] net/vmxnet3: uninitialized variable fix Thread-Index: AQHVC7Z2w/GeZNkN9USDsxO7J1hRtg== Date: Thu, 16 May 2019 07:10:38 +0000 Message-ID: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MR2P264CA0037.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::25) To DB6PR0902MB1829.eurprd09.prod.outlook.com (2603:10a6:4:b3::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogev@cgstowernetworks.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.9.1 x-originating-ip: [5.144.48.231] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1137f3ab-e6a8-4bb9-7cc1-08d6d9cd9929 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:DB6PR0902MB2198; x-ms-traffictypediagnostic: DB6PR0902MB2198: x-microsoft-antispam-prvs: <DB6PR0902MB219867053E4942F6E056B629D60A0@DB6PR0902MB2198.eurprd09.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:158; x-forefront-prvs: 0039C6E5C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(396003)(39830400003)(366004)(136003)(189003)(199004)(66946007)(66476007)(66556008)(73956011)(66446008)(64756008)(8936002)(86362001)(36756003)(508600001)(26005)(66066001)(99286004)(6512007)(4744005)(256004)(486006)(6436002)(52116002)(81166006)(81156014)(25786009)(50226002)(3846002)(6116002)(54906003)(6916009)(2351001)(5660300002)(4326008)(8676002)(71200400001)(71190400001)(1730700003)(5640700003)(53936002)(2906002)(6506007)(102836004)(71446004)(14454004)(305945005)(68736007)(476003)(186003)(6486002)(316002)(7736002)(386003)(2616005)(2501003); DIR:OUT; SFP:1102; SCL:1; SRVR:DB6PR0902MB2198; H:DB6PR0902MB1829.eurprd09.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cgstowernetworks.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WKBwoLHKG1sPTNUzUdd0jL+y3Rz6Gt6CLRhXYnT2v9gnGkddpBVYLrEkB3BKzLyZWQ21DeJkJPKs4LfLmXl3IEsEwGD9+MQJ8d3bqlEzgUUFtUqAqeIkk4AZrkcSt+GZJpMedPemkakODJGOz1vXXyjJsxqTIitzMqbmuWggCIwwbJLWAxkssGbn463aQt5mmYFCyQgB1qmV9CW+iVviORwqIDUCQABMjHvPHjLkhEsKPUDcCUOAfs/v2Ld19ehUb5HJqx2cxI18mhPd1dSo+JzCrAXxZNQPUCPuYyd2ZhJjJvA9Jv4z+6v0Ilk8cU/zaIm+CVpb1h/NIcTl2j2fSM0N0rluzVj4JSk/oxtwelIShfmpHU0Pu1VHv7khdAoGvHfApsyJMS8+fybF4roOxWatfpQfE8wcIqLI7/owAg8= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: cgstowernetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1137f3ab-e6a8-4bb9-7cc1-08d6d9cd9929 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2019 07:10:38.5023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc9e9498-07e8-4b82-b4cf-365bba23cbbf X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0902MB2198 Subject: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
net/vmxnet3: uninitialized variable fix
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Yogev Chaimovich
May 16, 2019, 7:10 a.m. UTC
Coverity issue: 323479
Fixes: 30f77abe net/vmxnet3: support stats reset
Cc: stable@dpdk.org
Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, May 16, 2019 at 9:10 AM Yogev Chaimovich <yogev@cgstowernetworks.com> wrote: I am not sure this is the right fix but I don't know this driver so I will let Yong comment on this. On the form, please, have a look at the recommandations for submitting patches: http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body Coverity issue: 323479 > Fixes: 30f77abe net/vmxnet3: support stats reset > Here, we would expect the Fixes: line as: Fixes: 30f77abecd38 ("net/vmxnet3: support stats reset") > Cc: stable@dpdk.org > > Signed-off-by: yogev ch <yogev@cgstowernetworks.com> > Iiuc, your sob line should be: Signed-off-by: Yogev Chaimovich <yogev@cgstowernetworks.com> --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index f54536b..c465996 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct > rte_pci_device *pci_dev) > { > unsigned int i; > struct vmxnet3_hw *hw = dev->data->dev_private; > - struct UPT1_TxStats txStats; > - struct UPT1_RxStats rxStats; > + struct UPT1_TxStats txStats = {0}; > + struct UPT1_RxStats rxStats = {0}; > > VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS); > > -- > 1.9.1 > >
-----Original Message----- From: Yogev Chaimovich <yogev@cgstowernetworks.com> Date: Thursday, May 16, 2019 at 12:10 AM To: Yong Wang <yongwang@vmware.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: [PATCH] net/vmxnet3: uninitialized variable fix Coverity issue: 323479 Fixes: 30f77abe net/vmxnet3: support stats reset Cc: stable@dpdk.org Signed-off-by: yogev ch <yogev@cgstowernetworks.com> --- Acked-by: Yong Wang <yongwang@vmware.com> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index f54536b..c465996 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev) { unsigned int i; struct vmxnet3_hw *hw = dev->data->dev_private; - struct UPT1_TxStats txStats; - struct UPT1_RxStats rxStats; + struct UPT1_TxStats txStats = {0}; + struct UPT1_RxStats rxStats = {0}; VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS); -- 1.9.1
On 5/20/2019 6:48 PM, Yong Wang wrote: > > -----Original Message----- > From: Yogev Chaimovich <yogev@cgstowernetworks.com> > Date: Thursday, May 16, 2019 at 12:10 AM > To: Yong Wang <yongwang@vmware.com> > Cc: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org> > Subject: [PATCH] net/vmxnet3: uninitialized variable fix > > Coverity issue: 323479 > Fixes: 30f77abe net/vmxnet3: support stats reset > Cc: stable@dpdk.org > > Signed-off-by: yogev ch <yogev@cgstowernetworks.com> > --- > > Acked-by: Yong Wang <yongwang@vmware.com> Applied to dpdk-next-net/master, thanks. (Suggestions from David applied.)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index f54536b..c465996 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev) { unsigned int i; struct vmxnet3_hw *hw = dev->data->dev_private; - struct UPT1_TxStats txStats; - struct UPT1_RxStats rxStats; + struct UPT1_TxStats txStats = {0}; + struct UPT1_RxStats rxStats = {0}; VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);