diff mbox series

[v2] eal: correct error log for alarm

Message ID 20190605071829.113385-1-xiaolong.ye@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] eal: correct error log for alarm |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Xiaolong Ye June 5, 2019, 7:18 a.m. UTC 
  Fixes: af75078fece3 ("first public release")
Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---

v2:

add freebsd fix suggested by David

 lib/librte_eal/freebsd/eal/eal.c | 2 +-
 lib/librte_eal/linux/eal/eal.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

David Marchand June 5, 2019, 7:31 a.m. UTC | #1 
On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> Fixes: af75078fece3 ("first public release")
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>
> v2:
>
> add freebsd fix suggested by David
>
>  lib/librte_eal/freebsd/eal/eal.c | 2 +-
>  lib/librte_eal/linux/eal/eal.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index c6ac9028f..a3b664125 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -663,7 +663,7 @@ rte_eal_init(int argc, char **argv)
>         }
>
>         if (rte_eal_alarm_init() < 0) {
> -               rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> +               rte_eal_init_alert("Cannot init alarm");
>                 /* rte_eal_alarm_init sets rte_errno on failure. */
>                 return -1;
>         }
> diff --git a/lib/librte_eal/linux/eal/eal.c
> b/lib/librte_eal/linux/eal/eal.c
> index 161399619..10e2887ca 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
>         }
>
>         if (rte_eal_alarm_init() < 0) {
> -               rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> +               rte_eal_init_alert("Cannot init alarm");
>                 /* rte_eal_alarm_init sets rte_errno on failure. */
>                 return -1;
>         }
> --
> 2.17.1
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon June 27, 2019, 3:02 p.m. UTC | #2 
05/06/2019 09:31, David Marchand:
> On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> 
> > Fixes: af75078fece3 ("first public release")
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c
index c6ac9028f..a3b664125 100644
--- a/lib/librte_eal/freebsd/eal/eal.c
+++ b/lib/librte_eal/freebsd/eal/eal.c
@@ -663,7 +663,7 @@  rte_eal_init(int argc, char **argv)
 	}
 
 	if (rte_eal_alarm_init() < 0) {
-		rte_eal_init_alert("Cannot init interrupt-handling thread");
+		rte_eal_init_alert("Cannot init alarm");
 		/* rte_eal_alarm_init sets rte_errno on failure. */
 		return -1;
 	}
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 161399619..10e2887ca 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1006,7 +1006,7 @@  rte_eal_init(int argc, char **argv)
 	}
 
 	if (rte_eal_alarm_init() < 0) {
-		rte_eal_init_alert("Cannot init interrupt-handling thread");
+		rte_eal_init_alert("Cannot init alarm");
 		/* rte_eal_alarm_init sets rte_errno on failure. */
 		return -1;
 	}