[v2] examples/multi_process: fix compilation error on FreeBSD
Checks
Commit Message
Caught on FreeBSD 12:
/usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
struct in_addr ip_src,ip_dst; /* source and dest address */
^~~~~~
On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
But actually, this header is not used in the example, just remove it.
Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v1:
- took the opposite approach, rather than fix the netinet/ip.h inclusion,
dropped it as it is unused
- added Fixes: tag
---
examples/multi_process/client_server_mp/mp_server/main.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> Caught on FreeBSD 12:
>
> /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
> struct in_addr ip_src,ip_dst; /* source and dest address */
> ^~~~~~
>
> On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> But actually, this header is not used in the example, just remove it.
>
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This should knock off one of the CI build errors once merged, I hope!
Thanks for doing the patch.
/Bruce
05/06/2019 14:50, Bruce Richardson:
> On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> > Caught on FreeBSD 12:
> >
> > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
> > struct in_addr ip_src,ip_dst; /* source and dest address */
> > ^~~~~~
> >
> > On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> > But actually, this header is not used in the example, just remove it.
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> This should knock off one of the CI build errors once merged, I hope!
> Thanks for doing the patch.
Applied, thanks
@@ -11,7 +11,6 @@
#include <inttypes.h>
#include <sys/queue.h>
#include <errno.h>
-#include <netinet/ip.h>
#include <signal.h>
#include <rte_common.h>