diff mbox series

mk: fix march for octeontx2 target

Message ID 20190702150619.12945-1-jerinj@marvell.com (mailing list archive)
State Accepted, archived
Headers
Series mk: fix march for octeontx2 target |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues
ci/mellanox-Performance-Testing fail Performance Testing issues
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Jerin Jacob Kollanukkaran July 2, 2019, 3:06 p.m. UTC 
  From: Jerin Jacob <jerinj@marvell.com>

Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for
octeontx2 target. Since rte_cc_has_argument drops invalid
CFLAG and -mcpu=octeontx2 picks up the correct optimization,
this typo is not noticed in performance testing.

Fixes: 01d184798731 ("config: add octeontx2 machine")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 mk/machine/octeontx2/rte.vars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon July 2, 2019, 9:57 p.m. UTC | #1 
02/07/2019 17:06, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for
> octeontx2 target. Since rte_cc_has_argument drops invalid
> CFLAG and -mcpu=octeontx2 picks up the correct optimization,
> this typo is not noticed in performance testing.
> 
> Fixes: 01d184798731 ("config: add octeontx2 machine")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks
diff mbox series

Patch

diff --git a/mk/machine/octeontx2/rte.vars.mk b/mk/machine/octeontx2/rte.vars.mk
index cbec7f14d..e209cf492 100644
--- a/mk/machine/octeontx2/rte.vars.mk
+++ b/mk/machine/octeontx2/rte.vars.mk
@@ -30,5 +30,5 @@ 
 
 include $(RTE_SDK)/mk/rte.helper.mk
 
-MACHINE_CFLAGS += $(call rte_cc_has_argument, -march=-mcpu=armv8.2-a+crc+crypto+lse)
+MACHINE_CFLAGS += $(call rte_cc_has_argument, -march=armv8.2-a+crc+crypto+lse)
 MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2)