diff mbox series

common/octeontx2: cleanup void returns

Message ID 20190708121833.4208-1-kkanas@marvell.com (mailing list archive)
State Accepted, archived
Headers
Series common/octeontx2: cleanup void returns |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Krzysztof Kanas July 8, 2019, 12:18 p.m. UTC 
  From: Krzysztof Kanas <kkanas@marvell.com>

mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value.
mbox_unregister_irq also returns void.

Clang with flags '-Wall -Wextra -pedantic' complains about:
void function should not return void expression

Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
---
 drivers/common/octeontx2/otx2_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon July 8, 2019, 1:29 p.m. UTC | #1 
08/07/2019 14:18, kkanas@marvell.com:
> From: Krzysztof Kanas <kkanas@marvell.com>
> 
> mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value.
> mbox_unregister_irq also returns void.
> 
> Clang with flags '-Wall -Wextra -pedantic' complains about:
> void function should not return void expression
> 
> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2/otx2_dev.c
index 53a0c6efbcbc..3b51fa93ad29 100644
--- a/drivers/common/octeontx2/otx2_dev.c
+++ b/drivers/common/octeontx2/otx2_dev.c
@@ -744,9 +744,9 @@  static void
 mbox_unregister_irq(struct rte_pci_device *pci_dev, struct otx2_dev *dev)
 {
 	if (otx2_dev_is_vf(dev))
-		return mbox_unregister_vf_irq(pci_dev, dev);
+		mbox_unregister_vf_irq(pci_dev, dev);
 	else
-		return mbox_unregister_pf_irq(pci_dev, dev);
+		mbox_unregister_pf_irq(pci_dev, dev);
 }
 
 static int