diff mbox series

[v1] examples/l3fwd-power: fix telemetry coverity issue

Message ID 20190710152620.9365-1-david.hunt@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] examples/l3fwd-power: fix telemetry coverity issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Hunt, David July 10, 2019, 3:26 p.m. UTC 
  6 issues caught by Coverity 343465
* Possible divide by zero on 3 lines
* Convert to float then back to int, losing precision on 3 lines

This patch modifies the code so that it only assigns calculated
values if the divisor is > 0, otherwise sets metrics to zero.
Also removes the un-needed round() function.

Coverity issue: 343465
Fixes: 609e79841fcf ("examples/l3fwd-power: add telemetry mode")
Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/l3fwd-power/main.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Comments

Thomas Monjalon July 10, 2019, 10 p.m. UTC | #1 
10/07/2019 17:26, David Hunt:
> 6 issues caught by Coverity 343465
> * Possible divide by zero on 3 lines
> * Convert to float then back to int, losing precision on 3 lines
> 
> This patch modifies the code so that it only assigns calculated
> values if the divisor is > 0, otherwise sets metrics to zero.
> Also removes the un-needed round() function.
> 
> Coverity issue: 343465
> Fixes: 609e79841fcf ("examples/l3fwd-power: add telemetry mode")
> Signed-off-by: David Hunt <david.hunt@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 99c1208ce..7a95605c4 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2100,9 +2100,16 @@  update_telemetry(__attribute__((unused)) struct rte_timer *tim,
 		rte_spinlock_unlock(&stats[lcore_id].telemetry_lock);
 	}
 
-	values[0] = round(app_eps/count);
-	values[1] = round(app_fps/count);
-	values[2] = round(app_br/count);
+	if (count > 0) {
+		values[0] = app_eps/count;
+		values[1] = app_fps/count;
+		values[2] = app_br/count;
+	} else {
+		values[0] = 0;
+		values[1] = 0;
+		values[2] = 0;
+	}
+
 	ret = rte_metrics_update_values(RTE_METRICS_GLOBAL, telstats_index,
 					values, RTE_DIM(values));
 	if (ret < 0)