diff mbox series

net/octeontx: use logtype_init for failed probe

Message ID 20190716114730.4b928469@hermes.lan (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series net/octeontx: use logtype_init for failed probe |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Stephen Hemminger July 16, 2019, 6:47 p.m. UTC 
  All log messages should use driver logtype. RTE_LOGTYPE_PMD is
planned to be deprecated in the future.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/octeontx/octeontx_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob Kollanukkaran July 19, 2019, 3:37 a.m. UTC | #1 
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 17, 2019 12:18 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

> All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> be deprecated in the future.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe
		
		

>  drivers/net/octeontx/octeontx_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c
> b/drivers/net/octeontx/octeontx_ethdev.c
> index 1b853399dfe4..27eed47bb0cb 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
>  	    strlen(rte_vdev_device_args(dev)) == 0) {
>  		eth_dev = rte_eth_dev_attach_secondary(dev_name);
>  		if (!eth_dev) {
> -			RTE_LOG(ERR, PMD, "Failed to probe %s\n",
> dev_name);
> +			PMD_INIT_LOG(ERR, "Failed to probe %s",
> dev_name);
>  			return -1;
>  		}
>  		/* TODO: request info from primary to set up Rx and Tx */
> --
> 2.20.1
Stephen Hemminger July 19, 2019, 4:59 p.m. UTC | #2 
On Fri, 19 Jul 2019 03:37:26 +0000
Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, July 17, 2019 12:18 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: dev@dpdk.org
> > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe  
> 
> > All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> > be deprecated in the future.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---  
> 
> Please fix
> 
> $ ./devtools/check-git-log.sh
> Wrong headline format:
>         net/octeontx: use logtype_init for failed probe
> 		

OK but

That rule in check-git-log is still ridiculous because it rejects perfectly good
commit subjects. The intention is good "stop automated bots" but the implementation
rejects too many good patches.
Jerin Jacob Kollanukkaran July 22, 2019, 8:05 a.m. UTC | #3 
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, July 19, 2019 10:29 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: Re: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
> 
> On Fri, 19 Jul 2019 03:37:26 +0000
> Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:
> 
> > > -----Original Message-----
> > > From: Stephen Hemminger <stephen@networkplumber.org>
> > > Sent: Wednesday, July 17, 2019 12:18 AM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > > Cc: dev@dpdk.org
> > > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed
> > > probe
> >
> > > All log messages should use driver logtype. RTE_LOGTYPE_PMD is
> > > planned to be deprecated in the future.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> >
> > Please fix
> >
> > $ ./devtools/check-git-log.sh
> > Wrong headline format:
> >         net/octeontx: use logtype_init for failed probe
> >

Changed the git commit to:
net/octeontx: use driver logtype

Applied to dpdk-next-net-mrvl/master. Thanks


> 
> OK but
> 
> That rule in check-git-log is still ridiculous because it rejects perfectly good
> commit subjects. The intention is good "stop automated bots" but the
> implementation rejects too many good patches.
diff mbox series

Patch

diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 1b853399dfe4..27eed47bb0cb 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -1175,7 +1175,7 @@  octeontx_probe(struct rte_vdev_device *dev)
 	    strlen(rte_vdev_device_args(dev)) == 0) {
 		eth_dev = rte_eth_dev_attach_secondary(dev_name);
 		if (!eth_dev) {
-			RTE_LOG(ERR, PMD, "Failed to probe %s\n", dev_name);
+			PMD_INIT_LOG(ERR, "Failed to probe %s", dev_name);
 			return -1;
 		}
 		/* TODO: request info from primary to set up Rx and Tx */