test: enable installing test app with meson
Checks
Commit Message
Currently, the test app is not being installed by default when
built and installed with meson build system. Fix that to enable
installation of the test app alongside other DPDK apps.
Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
Cc: harry.van.haaren@intel.com
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/test/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote:
> Currently, the test app is not being installed by default when
> built and installed with meson build system. Fix that to enable
> installation of the test app alongside other DPDK apps.
>
> Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> Cc: harry.van.haaren@intel.com
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 1834897bf..c50b20275 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test',
> dependencies: test_dep_objs,
> c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
> install_rpath: driver_install_path,
> - install: false)
> + install: true)
>
I see no major reason not to have it installed - if anyone does not want
the test app, they can disable it completely using the meson option
"tests". Therefore:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
24/07/2019 17:50, Bruce Richardson:
> On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote:
> > Currently, the test app is not being installed by default when
> > built and installed with meson build system. Fix that to enable
> > installation of the test app alongside other DPDK apps.
> >
> > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> > Cc: harry.van.haaren@intel.com
> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> I see no major reason not to have it installed - if anyone does not want
> the test app, they can disable it completely using the meson option
> "tests". Therefore:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
@@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test',
dependencies: test_dep_objs,
c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
install_rpath: driver_install_path,
- install: false)
+ install: true)
# some perf tests (eg: memcpy perf autotest)take very long
# to complete, so timeout to 10 minutes