diff mbox series

[3/8] net/null: remove unused Tx error counter

Message ID	1564046068-21905-4-git-send-email-david.marchand@redhat.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Ferruh Yigit
Headers	From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Tetsuya Mukawa <mtetsuyah@gmail.com> Date: Thu, 25 Jul 2019 11:14:23 +0200 Message-Id: <1564046068-21905-4-git-send-email-david.marchand@redhat.com> In-Reply-To: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> Subject: [dpdk-dev] [PATCH 3/8] net/null: remove unused Tx error counter Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	oerrors stats fixes for virtual pmds \| [0/8] oerrors stats fixes for virtual pmds [1/8] net/af_packet: remove unused Rx counter [2/8] net/af_xdp: remove unused Tx counter [3/8] net/null: remove unused Tx error counter [4/8] net/virtio: remove unused Tx error counter [5/8] net/kni: do not count unsent packets as errors [6/8] net/memif: do not count unsent packets as errors [7/8] net/ring: do not count unsent packets as errors [8/8] net/vhost: do not count unsent packets as errors

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

David Marchand July 25, 2019, 9:14 a.m. UTC

  This Tx counter has never been used.

Fixes: c743e50c475f ("null: new poll mode driver")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/null/rte_eth_null.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Ferruh Yigit July 25, 2019, 4:06 p.m. UTC | #1

On 7/25/2019 10:14 AM, David Marchand wrote:
> This Tx counter has never been used.
> 
> Fixes: c743e50c475f ("null: new poll mode driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

diff mbox series

Patch

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 31cbb84..b2c92ab 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -62,7 +62,6 @@  struct null_queue {
 
 	rte_atomic64_t rx_pkts;
 	rte_atomic64_t tx_pkts;
-	rte_atomic64_t err_pkts;
 };
 
 struct pmd_internals {
@@ -311,7 +310,7 @@  static int
 eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 {
 	unsigned i, num_stats;
-	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
+	unsigned long rx_total = 0, tx_total = 0;
 	const struct pmd_internals *internal;
 
 	if ((dev == NULL) || (igb_stats == NULL))
@@ -334,12 +333,10 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 		igb_stats->q_opackets[i] =
 			internal->tx_null_queues[i].tx_pkts.cnt;
 		tx_total += igb_stats->q_opackets[i];
-		tx_err_total += internal->tx_null_queues[i].err_pkts.cnt;
 	}
 
 	igb_stats->ipackets = rx_total;
 	igb_stats->opackets = tx_total;
-	igb_stats->oerrors = tx_err_total;
 
 	return 0;
 }
@@ -356,10 +353,8 @@  eth_stats_reset(struct rte_eth_dev *dev)
 	internal = dev->data->dev_private;
 	for (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)
 		internal->rx_null_queues[i].rx_pkts.cnt = 0;
-	for (i = 0; i < RTE_DIM(internal->tx_null_queues); i++) {
+	for (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)
 		internal->tx_null_queues[i].tx_pkts.cnt = 0;
-		internal->tx_null_queues[i].err_pkts.cnt = 0;
-	}
 }
 
 static void