diff mbox series

[RFC,v4] ethdev: extend RSS offload types

Message ID 1564635299-139306-1-git-send-email-simei.su@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [RFC,v4] ethdev: extend RSS offload types |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Simei Su Aug. 1, 2019, 4:54 a.m. UTC 
  From: Simei Su <simei.su@intel.com>

This RFC cover two aspects:
   (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve
      different purposes.

   (2)reserve several bits as input set selection from bottom
      of the 64 bits.It is combined with exisiting ETH_RSS_* to
      represent rss types.

   for example:
     ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only
     ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on src/dst IP and
				             dst UDP port
     ETH_RSS_L2_PAYLOAD | ETH_RSS_L2_DST_ONLY: hash on dst mac address

   Testpmd modification part will be send out in later formal patch.

Signed-off-by: Simei Su <simei.su@intel.com>
---
 lib/librte_ethdev/rte_ethdev.h | 61 +++++++++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 25 deletions(-)
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index dc6596b..9caf2bb 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -482,31 +482,42 @@  struct rte_eth_rss_conf {
 #define RTE_ETH_FLOW_MAX                23
 
 /*
- * The RSS offload types are defined based on flow types.
- * Different NIC hardware may support different RSS offload
- * types. The supported flow types or RSS offload types can be queried by
- * rte_eth_dev_info_get().
- */
-#define ETH_RSS_IPV4               (1ULL << RTE_ETH_FLOW_IPV4)
-#define ETH_RSS_FRAG_IPV4          (1ULL << RTE_ETH_FLOW_FRAG_IPV4)
-#define ETH_RSS_NONFRAG_IPV4_TCP   (1ULL << RTE_ETH_FLOW_NONFRAG_IPV4_TCP)
-#define ETH_RSS_NONFRAG_IPV4_UDP   (1ULL << RTE_ETH_FLOW_NONFRAG_IPV4_UDP)
-#define ETH_RSS_NONFRAG_IPV4_SCTP  (1ULL << RTE_ETH_FLOW_NONFRAG_IPV4_SCTP)
-#define ETH_RSS_NONFRAG_IPV4_OTHER (1ULL << RTE_ETH_FLOW_NONFRAG_IPV4_OTHER)
-#define ETH_RSS_IPV6               (1ULL << RTE_ETH_FLOW_IPV6)
-#define ETH_RSS_FRAG_IPV6          (1ULL << RTE_ETH_FLOW_FRAG_IPV6)
-#define ETH_RSS_NONFRAG_IPV6_TCP   (1ULL << RTE_ETH_FLOW_NONFRAG_IPV6_TCP)
-#define ETH_RSS_NONFRAG_IPV6_UDP   (1ULL << RTE_ETH_FLOW_NONFRAG_IPV6_UDP)
-#define ETH_RSS_NONFRAG_IPV6_SCTP  (1ULL << RTE_ETH_FLOW_NONFRAG_IPV6_SCTP)
-#define ETH_RSS_NONFRAG_IPV6_OTHER (1ULL << RTE_ETH_FLOW_NONFRAG_IPV6_OTHER)
-#define ETH_RSS_L2_PAYLOAD         (1ULL << RTE_ETH_FLOW_L2_PAYLOAD)
-#define ETH_RSS_IPV6_EX            (1ULL << RTE_ETH_FLOW_IPV6_EX)
-#define ETH_RSS_IPV6_TCP_EX        (1ULL << RTE_ETH_FLOW_IPV6_TCP_EX)
-#define ETH_RSS_IPV6_UDP_EX        (1ULL << RTE_ETH_FLOW_IPV6_UDP_EX)
-#define ETH_RSS_PORT               (1ULL << RTE_ETH_FLOW_PORT)
-#define ETH_RSS_VXLAN              (1ULL << RTE_ETH_FLOW_VXLAN)
-#define ETH_RSS_GENEVE             (1ULL << RTE_ETH_FLOW_GENEVE)
-#define ETH_RSS_NVGRE              (1ULL << RTE_ETH_FLOW_NVGRE)
+ * Here, we decouple RTE_ETH_FLOW_* and ETH_RSS_*. The following macros only
+ * make sense for RSS.
+ */
+#define ETH_RSS_IPV4			(1ULL << 2)
+#define ETH_RSS_FRAG_IPV4		(1ULL << 3)
+#define ETH_RSS_NONFRAG_IPV4_TCP	(1ULL << 4)
+#define ETH_RSS_NONFRAG_IPV4_UDP	(1ULL << 5)
+#define ETH_RSS_NONFRAG_IPV4_SCTP	(1ULL << 6)
+#define ETH_RSS_NONFRAG_IPV4_OTHER	(1ULL << 7)
+#define ETH_RSS_IPV6			(1ULL << 8)
+#define ETH_RSS_FRAG_IPV6		(1ULL << 9)
+#define ETH_RSS_NONFRAG_IPV6_TCP	(1ULL << 10)
+#define ETH_RSS_NONFRAG_IPV6_UDP	(1ULL << 11)
+#define ETH_RSS_NONFRAG_IPV6_SCTP	(1ULL << 12)
+#define ETH_RSS_NONFRAG_IPV6_OTHER	(1ULL << 13)
+#define ETH_RSS_L2_PAYLOAD		(1ULL << 14)
+#define ETH_RSS_IPV6_EX			(1ULL << 15)
+#define ETH_RSS_IPV6_TCP_EX		(1ULL << 16)
+#define ETH_RSS_IPV6_UDP_EX		(1ULL << 17)
+#define ETH_RSS_PORT			(1ULL << 18)
+#define ETH_RSS_VXLAN			(1ULL << 19)
+#define ETH_RSS_GENEVE			(1ULL << 20)
+#define ETH_RSS_NVGRE			(1ULL << 21)
+
+/* The following six macros are used combined with ETH_RSS_* to
+ * represent rss types. The structure rte_flow_action_rss.types is
+ * 64-bit wide and we reserve couple bits here for input set selection
+ * from bottom of the 64 bits so that it doesn't impact future
+ * ETH_RSS_* definitions.
+ */
+#define	ETH_RSS_L2_SRC_ONLY		(1ULL << 63)
+#define	ETH_RSS_L2_DST_ONLY		(1ULL << 62)
+#define	ETH_RSS_L3_SRC_ONLY		(1ULL << 61)
+#define	ETH_RSS_L3_DST_ONLY		(1ULL << 60)
+#define	ETH_RSS_L4_SRC_ONLY		(1ULL << 59)
+#define	ETH_RSS_L4_DST_ONLY		(1ULL << 58)
 
 #define ETH_RSS_IP ( \
 	ETH_RSS_IPV4 | \