[v2] net/memif: fix multi-process malfunctioning device

Message ID 1565081126-14432-1-git-send-email-phil.yang@arm.com (mailing list archive)
State Accepted, archived
Headers
Series [v2] net/memif: fix multi-process malfunctioning device |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Phil Yang Aug. 6, 2019, 8:45 a.m. UTC
  When working as a secondary process, it uses eth_memif_rx in PMD egress.
It should be eth_memif_tx.

Fixes: c41a04958b ("net/memif: support multi-process")

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
v2:
Add descriptions in commit log.

v1:
Initial version.

 drivers/net/memif/rte_eth_memif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon Aug. 6, 2019, 9:28 a.m. UTC | #1
06/08/2019 10:45, Phil Yang:
> When working as a secondary process, it uses eth_memif_rx in PMD egress.
> It should be eth_memif_tx.
> 
> Fixes: c41a04958b ("net/memif: support multi-process")
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

Applied, thanks

Instead of the vague "malfunctioning device",
I replaced with "Tx" in the title.
  

Patch

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index bcda426..a59f809 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1265,7 +1265,7 @@  rte_pmd_memif_probe(struct rte_vdev_device *vdev)
 		eth_dev->dev_ops = &ops;
 		eth_dev->device = &vdev->device;
 		eth_dev->rx_pkt_burst = eth_memif_rx;
-		eth_dev->tx_pkt_burst = eth_memif_rx;
+		eth_dev->tx_pkt_burst = eth_memif_tx;
 
 		if (!rte_eal_primary_proc_alive(NULL)) {
 			MIF_LOG(ERR, "Primary process is missing");