diff mbox series

net/atlantic: get rid of double declaration of dev info get

Message ID 1567348603-16292-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/atlantic: get rid of double declaration of dev info get |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-dpdk_compile_ovs success Compile Testing PASS
ci/iol-dpdk_compile success Compile Testing PASS
ci/iol-dpdk_compile_spdk success Compile Testing PASS
ci/intel-Performance success Performance Testing PASS
ci/mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Andrew Rybchenko Sept. 1, 2019, 2:36 p.m. UTC 
  From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>

atl_dev_info_get() is declared twice in atl_ethdev.c.
Delete one of these declararions.

Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
Cc: stable@dpdk.org

Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/atlantic/atl_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Igor Russkikh Sept. 2, 2019, 10:32 a.m. UTC | #1 
On 01.09.2019 17:36, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> 
> atl_dev_info_get() is declared twice in atl_ethdev.c.
> Delete one of these declararions.
> 
> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Thanks for noticing Andrew, Ivan.

Ack.

Regards,
  Igor
Ferruh Yigit Sept. 2, 2019, 4:20 p.m. UTC | #2 
On 9/2/2019 11:32 AM, Igor Russkikh wrote:
> 
> 
> On 01.09.2019 17:36, Andrew Rybchenko wrote:
>> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>>
>> atl_dev_info_get() is declared twice in atl_ethdev.c.
>> Delete one of these declararions.
>>
>> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Thanks for noticing Andrew, Ivan.
> 
> Ack.
> 
> Regards,
>   Igor
> 

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c
index 3c1b349..4a99699 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -45,9 +45,6 @@  static int atl_dev_xstats_get(struct rte_eth_dev *dev,
 static int atl_fw_version_get(struct rte_eth_dev *dev, char *fw_version,
 			      size_t fw_size);
 
-static void atl_dev_info_get(struct rte_eth_dev *dev,
-			       struct rte_eth_dev_info *dev_info);
-
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
 static int atl_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);