Message ID | 1567519051-28189-24-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524EE1EBB3; Tue, 3 Sep 2019 15:58:50 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E96F71E949 for <dev@dpdk.org>; Tue, 3 Sep 2019 15:58:00 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C021968007C; Tue, 3 Sep 2019 13:57:59 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Sep 2019 06:57:55 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 3 Sep 2019 06:57:55 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x83Dvsd5000466; Tue, 3 Sep 2019 14:57:54 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 524AA1613D1; Tue, 3 Sep 2019 14:57:54 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: John McNamara <john.mcnamara@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Harry van Haaren <harry.van.haaren@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com> CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Date: Tue, 3 Sep 2019 14:56:57 +0100 Message-ID: <1567519051-28189-24-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1567519051-28189-1-git-send-email-arybchenko@solarflare.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567519051-28189-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24886.005 X-TM-AS-Result: No-0.687700-4.000000-10 X-TMASE-MatchedRID: qkiRFh4owgXDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhrny O1e9qRizrdoLblq9S5qFHooe6FVT4PJkmPKQqKVldPuue3cRiRgyyi+n+H050Vb7wH1qzBDbHDP vbMPO+Q4zR/hlQA0tpCJ1igIe5xA1h3sgSWUWxIOwVIp8Y8imtcZiegX8JN5lmyiLZetSf8mfop 0ytGwvXiq2rl3dzGQ1w6jkIBQTNfORsDhGcDwpz+q1C/pyU+fQjkA2qjPrqgQxmmrHx/gmDNTfB bAHPQyT4D2X37qaakefz3FsMupzcLn5LM3y0t3YoWtvT8cnZ0E4oGQUCbwY5Q+g7mdwjo656FtD ZCmYBJ3KTLw/lNgw8g== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.687700-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24886.005 X-MDID: 1567519080-tgH0L4A-9CHf Subject: [dpdk-dev] [PATCH v2 23/54] examples/vmdq: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: change rte_eth_dev_info_get() return value to int
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Andrew Rybchenko
Sept. 3, 2019, 1:56 p.m. UTC
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vmdq according to its new return type. Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- examples/vmdq/main.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index 7281ffd..91f9a99 100644 --- a/examples/vmdq/main.c +++ b/examples/vmdq/main.c @@ -169,7 +169,13 @@ * The max pool number from dev_info will be used to validate the pool * number specified in cmd line */ - rte_eth_dev_info_get(port, &dev_info); + retval = rte_eth_dev_info_get(port, &dev_info); + if (retval != 0) { + printf("Error during getting device (port %u) info: %s\n", + port, strerror(-retval)); + return retval; + } + max_nb_pools = (uint32_t)dev_info.max_vmdq_pools; /* * We allow to process part of VMDQ pools specified by num_pools in @@ -214,7 +220,13 @@ rxRings = (uint16_t)dev_info.max_rx_queues; txRings = (uint16_t)dev_info.max_tx_queues; - rte_eth_dev_info_get(port, &dev_info); + retval = rte_eth_dev_info_get(port, &dev_info); + if (retval != 0) { + printf("Error during getting device (port %u) info: %s\n", + port, strerror(-retval)); + return retval; + } + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE;