Message ID | 1567755066-31389-28-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 507531F21C; Fri, 6 Sep 2019 09:33:00 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9F3551F185 for <dev@dpdk.org>; Fri, 6 Sep 2019 09:32:01 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BAEB19C0059; Fri, 6 Sep 2019 07:32:00 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Sep 2019 00:31:54 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 6 Sep 2019 00:31:54 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x867Vrq4027718; Fri, 6 Sep 2019 08:31:53 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 6158F1613D1; Fri, 6 Sep 2019 08:31:53 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Jasvinder Singh <jasvinder.singh@intel.com> CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Date: Fri, 6 Sep 2019 08:30:39 +0100 Message-ID: <1567755066-31389-28-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1567755066-31389-1-git-send-email-arybchenko@solarflare.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.005 X-TM-AS-Result: No-2.696000-4.000000-10 X-TMASE-MatchedRID: yxMxR3EH7TrDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhlMe 5Blkpry7rdoLblq9S5pwBR4qxUW4Q15UNxzJViZjimHWEC28pk36vcMg7A/gpSKRngfL8yYC0c8 aNDRHFani8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvt3Nnh2IKgDQEfMT0hDUZSUt80MI+6US/rbPL zBR2HCmIfJ4W2Swt5dVSTXIRmp7SLgBTnFe0m/q/Ko40Lv3kFzhbCIX1f/e1q9Tbikt9AWZ0CBS GS7bIBtA1B/p1SzcogrKiD/U8b7SYci0ewgZmW0ftwZ3X11IV0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.696000-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.005 X-MDID: 1567755121-8TcqPFnc6qLb Subject: [dpdk-dev] [PATCH v3 27/54] examples/qos_sched: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: change rte_eth_dev_info_get() return value to int
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Andrew Rybchenko
Sept. 6, 2019, 7:30 a.m. UTC
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/qos_sched according to its new return type. Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- examples/qos_sched/init.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Friday, September 6, 2019 8:31 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder > <jasvinder.singh@intel.com> > Cc: dev@dpdk.org; Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > Subject: [PATCH v3 27/54] examples/qos_sched: check status of getting ethdev > info > > From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > > rte_eth_dev_info_get() return value was changed from void to int, so this > patch modify rte_eth_dev_info_get() usage across examples/qos_sched > according to its new return type. > > Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> > --- > examples/qos_sched/init.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index > b05206d5ab..cf9e8f4ac7 100644 > --- a/examples/qos_sched/init.c > +++ b/examples/qos_sched/init.c > @@ -98,7 +98,13 @@ app_init_port(uint16_t portid, struct rte_mempool > *mp) > /* init port */ > RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid); > fflush(stdout); > - rte_eth_dev_info_get(portid, &dev_info); > + > + ret = rte_eth_dev_info_get(portid, &dev_info); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + "Error during getting device (port %u) info: %s\n", > + portid, strerror(-ret)); > + > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > local_port_conf.txmode.offloads |= > DEV_TX_OFFLOAD_MBUF_FAST_FREE; > -- > 2.17.1 Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index b05206d5ab..cf9e8f4ac7 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -98,7 +98,13 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) /* init port */ RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); + + ret = rte_eth_dev_info_get(portid, &dev_info); + if (ret != 0) + rte_exit(EXIT_FAILURE, + "Error during getting device (port %u) info: %s\n", + portid, strerror(-ret)); + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) local_port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE;