diff mbox series

test/event_crypto: add check for adapter failure

Message ID 20190927081606.22931-3-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series test/event_crypto: add check for adapter failure |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK
ci/iol-dpdk_compile_ovs success Compile Testing PASS
ci/iol-dpdk_compile success Compile Testing PASS
ci/iol-dpdk_compile_spdk success Compile Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Hemant Agrawal Sept. 27, 2019, 8:16 a.m. UTC 
  Return err if the adapter creation is failed.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/test/test_event_crypto_adapter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Gujjar, Abhinandan S Sept. 27, 2019, 10:10 a.m. UTC | #1 
Acked-by: abhinandan.gujjar@intel.com

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: add check for adapter failure
> 
> Return err if the adapter creation is failed.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test/test_event_crypto_adapter.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 83f3214ca..275729ba6 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -814,7 +814,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
>  	enum rte_event_crypto_adapter_mode mode;
> 
>  	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
> -	test_crypto_adapter_conf(mode);
> +	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> +				"Failed to config crypto adapter");
> 
>  	return TEST_SUCCESS;
>  }
> @@ -825,7 +826,9 @@ test_crypto_adapter_conf_op_new_mode(void)
>  	enum rte_event_crypto_adapter_mode mode;
> 
>  	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
> -	test_crypto_adapter_conf(mode);
> +	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> +				"Failed to config crypto adapter");
> +
>  	return TEST_SUCCESS;
>  }
> 
> --
> 2.17.1
Jerin Jacob Sept. 30, 2019, 1:27 p.m. UTC | #2 
On Fri, Sep 27, 2019 at 3:40 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com


Changed to  Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.



>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 27, 2019 1:46 PM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: add check for adapter failure
> >
> > Return err if the adapter creation is failed.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 83f3214ca..275729ba6 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -814,7 +814,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
> >       enum rte_event_crypto_adapter_mode mode;
> >
> >       mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
> > -     test_crypto_adapter_conf(mode);
> > +     TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> > +                             "Failed to config crypto adapter");
> >
> >       return TEST_SUCCESS;
> >  }
> > @@ -825,7 +826,9 @@ test_crypto_adapter_conf_op_new_mode(void)
> >       enum rte_event_crypto_adapter_mode mode;
> >
> >       mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
> > -     test_crypto_adapter_conf(mode);
> > +     TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> > +                             "Failed to config crypto adapter");
> > +
> >       return TEST_SUCCESS;
> >  }
> >
> > --
> > 2.17.1
>
diff mbox series

Patch

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 83f3214ca..275729ba6 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -814,7 +814,8 @@  test_crypto_adapter_conf_op_forward_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
-	test_crypto_adapter_conf(mode);
+	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
+				"Failed to config crypto adapter");
 
 	return TEST_SUCCESS;
 }
@@ -825,7 +826,9 @@  test_crypto_adapter_conf_op_new_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
-	test_crypto_adapter_conf(mode);
+	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
+				"Failed to config crypto adapter");
+
 	return TEST_SUCCESS;
 }