examples/ipsec-secgw: update pkttest requirements
Checks
Commit Message
Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
used because 2.4.2 had a bug which made this version unable to install.
Accept future versions of Scapy too.
Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
---
examples/ipsec-secgw/test/pkttest.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Smoczynski, MarcinX
> Sent: Wednesday, October 2, 2019 9:50 AM
> To: akhil.goyal@nxp.com; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Smoczynski, MarcinX <marcinx.smoczynski@intel.com>
> Subject: [PATCH] examples/ipsec-secgw: update pkttest requirements
>
> Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
> used because 2.4.2 had a bug which made this version unable to install.
> Accept future versions of Scapy too.
>
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> ---
> examples/ipsec-secgw/test/pkttest.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/test/pkttest.py b/examples/ipsec-secgw/test/pkttest.py
> index bcad2156b..5250727f4 100755
> --- a/examples/ipsec-secgw/test/pkttest.py
> +++ b/examples/ipsec-secgw/test/pkttest.py
> @@ -21,7 +21,7 @@
>
>
> PKTTEST_REQ = [
> - "scapy==2.4.3rc1",
> + "scapy>=2.4.3",
> ]
>
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.17.1
> >
> > Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
> > used because 2.4.2 had a bug which made this version unable to install.
Is this 2.4.2 or 2.4.3??
> > Accept future versions of Scapy too.
> >
> > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
I've used 2.4.3rc1 in the first place because 2.4.2 which was the latest
version at that time had a bug which made it unable to install.
2.4.3rc1 worked fine.
2.4.3 has been released recently so we are moving from pre-release RC
to stable version. Thanks to ">=" in the requirement we won't need
to update it in the future.
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, October 3, 2019 10:30 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Smoczynski,
> MarcinX <marcinx.smoczynski@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] examples/ipsec-secgw: update pkttest requirements
>
> > >
> > > Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has
> > > been used because 2.4.2 had a bug which made this version unable to
> install.
>
> Is this 2.4.2 or 2.4.3??
>
> > > Accept future versions of Scapy too.
> > >
> > > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> >
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >
@@ -21,7 +21,7 @@
PKTTEST_REQ = [
- "scapy==2.4.3rc1",
+ "scapy>=2.4.3",
]