examples/ipsec-secgw: update pkttest requirements

Message ID 20191002085016.10520-1-marcinx.smoczynski@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series examples/ipsec-secgw: update pkttest requirements |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-compilation success Compile Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Marcin Smoczynski Oct. 2, 2019, 8:50 a.m. UTC
  Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
used because 2.4.2 had a bug which made this version unable to install.
Accept future versions of Scapy too.

Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
---
 examples/ipsec-secgw/test/pkttest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ananyev, Konstantin Oct. 2, 2019, 8:53 a.m. UTC | #1
> -----Original Message-----
> From: Smoczynski, MarcinX
> Sent: Wednesday, October 2, 2019 9:50 AM
> To: akhil.goyal@nxp.com; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Smoczynski, MarcinX <marcinx.smoczynski@intel.com>
> Subject: [PATCH] examples/ipsec-secgw: update pkttest requirements
> 
> Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
> used because 2.4.2 had a bug which made this version unable to install.
> Accept future versions of Scapy too.
> 
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> ---
>  examples/ipsec-secgw/test/pkttest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ipsec-secgw/test/pkttest.py b/examples/ipsec-secgw/test/pkttest.py
> index bcad2156b..5250727f4 100755
> --- a/examples/ipsec-secgw/test/pkttest.py
> +++ b/examples/ipsec-secgw/test/pkttest.py
> @@ -21,7 +21,7 @@
> 
> 
>  PKTTEST_REQ = [
> -    "scapy==2.4.3rc1",
> +    "scapy>=2.4.3",
>  ]
> 
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1
  
Akhil Goyal Oct. 3, 2019, 8:29 a.m. UTC | #2
> >
> > Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been
> > used because 2.4.2 had a bug which made this version unable to install.

Is this 2.4.2 or 2.4.3??

> > Accept future versions of Scapy too.
> >
> > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
  
Marcin Smoczynski Oct. 3, 2019, 8:55 a.m. UTC | #3
I've used 2.4.3rc1 in the first place because 2.4.2 which was the latest
version at that time had a bug which made it unable to install.
2.4.3rc1 worked fine.

2.4.3 has been released recently so we are moving from pre-release RC
to stable version. Thanks to ">=" in the requirement we won't need
to update it in the future.

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, October 3, 2019 10:30 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Smoczynski,
> MarcinX <marcinx.smoczynski@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] examples/ipsec-secgw: update pkttest requirements
> 
> > >
> > > Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has
> > > been used because 2.4.2 had a bug which made this version unable to
> install.
> 
> Is this 2.4.2 or 2.4.3??
> 
> > > Accept future versions of Scapy too.
> > >
> > > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> >
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >
  

Patch

diff --git a/examples/ipsec-secgw/test/pkttest.py b/examples/ipsec-secgw/test/pkttest.py
index bcad2156b..5250727f4 100755
--- a/examples/ipsec-secgw/test/pkttest.py
+++ b/examples/ipsec-secgw/test/pkttest.py
@@ -21,7 +21,7 @@ 
 
 
 PKTTEST_REQ = [
-    "scapy==2.4.3rc1",
+    "scapy>=2.4.3",
 ]