[10/10] net/bnxt: remove a useless check in validate flow routine
Checks
Commit Message
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Since vnic->rx_queue_cnt is already checked against non-zero,
removed the useless check from the inside condition check.
Fixes: 4be31562a4ba ("net/bnxt: allow flow creation when RSS is enabled")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_flow.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 10/4/2019 6:02 AM, Ajit Khaparde wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Since vnic->rx_queue_cnt is already checked against non-zero,
> removed the useless check from the inside condition check.
>
> Fixes: 4be31562a4ba ("net/bnxt: allow flow creation when RSS is enabled")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Squashed into relevant commit in next-net, thanks.
(please send new version of the patchset on top of latest next-net)
@@ -1067,8 +1067,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
goto ret;
}
if (vnic->rx_queue_cnt) {
- if (vnic->rx_queue_cnt > 1 ||
- vnic->start_grp_id != act_q->index) {
+ if (vnic->start_grp_id != act_q->index) {
PMD_DRV_LOG(ERR,
"VNIC already in use\n");
rte_flow_error_set(error,