rcu: fix reference to offline function

Message ID 1571392673-27643-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series rcu: fix reference to offline function |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed

Commit Message

David Marchand Oct. 18, 2019, 9:57 a.m. UTC
  Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
I intend to add this patch to this series.
Honnappa, can you review it please ?

---
 lib/librte_rcu/rte_rcu_qsbr.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Honnappa Nagarahalli Oct. 18, 2019, 1:58 p.m. UTC | #1
<snip>

> Subject: [PATCH] rcu: fix reference to offline function
> 
> Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> I intend to add this patch to this series.
> Honnappa, can you review it please ?
> 
> ---
>  lib/librte_rcu/rte_rcu_qsbr.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h index
> 0d46645..0b55859 100644
> --- a/lib/librte_rcu/rte_rcu_qsbr.h
> +++ b/lib/librte_rcu/rte_rcu_qsbr.h
> @@ -217,7 +217,7 @@ struct rte_rcu_qsbr {
>   * call this API before calling rte_rcu_qsbr_quiescent. This can be called
>   * during initialization or as part of the packet processing loop.
>   *
> - * The reader thread must call rte_rcu_thread_offline API, before
> + * The reader thread must call rte_rcu_qsbr_thread_offline API, before
>   * calling any functions that block, to ensure that rte_rcu_qsbr_check
>   * API does not wait indefinitely for the reader thread to update its QS.
>   *
> @@ -283,7 +283,7 @@ struct rte_rcu_qsbr {
>   * This can be called during initialization or as part of the packet
>   * processing loop.
>   *
> - * The reader thread must call rte_rcu_thread_offline API, before
> + * The reader thread must call rte_rcu_qsbr_thread_offline API, before
>   * calling any functions that block, to ensure that rte_rcu_qsbr_check
>   * API does not wait indefinitely for the reader thread to update its QS.
>   *
> --
> 1.8.3.1
Thank you David.
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
  
David Marchand Oct. 21, 2019, 7:25 p.m. UTC | #2
On Fri, Oct 18, 2019 at 3:58 PM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> <snip>
>
> > Subject: [PATCH] rcu: fix reference to offline function
> >
> > Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>

Applied.
  

Patch

diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h
index 0d46645..0b55859 100644
--- a/lib/librte_rcu/rte_rcu_qsbr.h
+++ b/lib/librte_rcu/rte_rcu_qsbr.h
@@ -217,7 +217,7 @@  struct rte_rcu_qsbr {
  * call this API before calling rte_rcu_qsbr_quiescent. This can be called
  * during initialization or as part of the packet processing loop.
  *
- * The reader thread must call rte_rcu_thread_offline API, before
+ * The reader thread must call rte_rcu_qsbr_thread_offline API, before
  * calling any functions that block, to ensure that rte_rcu_qsbr_check
  * API does not wait indefinitely for the reader thread to update its QS.
  *
@@ -283,7 +283,7 @@  struct rte_rcu_qsbr {
  * This can be called during initialization or as part of the packet
  * processing loop.
  *
- * The reader thread must call rte_rcu_thread_offline API, before
+ * The reader thread must call rte_rcu_qsbr_thread_offline API, before
  * calling any functions that block, to ensure that rte_rcu_qsbr_check
  * API does not wait indefinitely for the reader thread to update its QS.
  *