diff mbox series

net/ice: fix IPv6 UDP port matching failure issue

Message ID 20191024125637.10530-1-yahui.cao@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ice: fix IPv6 UDP port matching failure issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Cao, Yahui Oct. 24, 2019, 12:56 p.m. UTC 
  Reverse the src and dest notion, since the HW expects them to be from Tx
perspective where as the input from user is from Rx filter view.

Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy")

Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
 drivers/net/ice/ice_fdir_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xiaolong Ye Oct. 24, 2019, 6:07 a.m. UTC | #1 
On 10/24, Yahui Cao wrote:
>Reverse the src and dest notion, since the HW expects them to be from Tx
>perspective where as the input from user is from Rx filter view.
>
>Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy")
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index a85a02cd0..736ccd54e 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -1609,9 +1609,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
> 						ICE_FLTR_PTYPE_NONF_IPV4_UDP;
> 				} else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
> 					filter->input.ip.v6.src_port =
>-						udp_spec->hdr.src_port;
>-					filter->input.ip.v6.dst_port =
> 						udp_spec->hdr.dst_port;
>+					filter->input.ip.v6.dst_port =
>+						udp_spec->hdr.src_port;
> 					flow_type =
> 						ICE_FLTR_PTYPE_NONF_IPV6_UDP;
> 				}
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel.
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index a85a02cd0..736ccd54e 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -1609,9 +1609,9 @@  ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
 						ICE_FLTR_PTYPE_NONF_IPV4_UDP;
 				} else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
 					filter->input.ip.v6.src_port =
-						udp_spec->hdr.src_port;
-					filter->input.ip.v6.dst_port =
 						udp_spec->hdr.dst_port;
+					filter->input.ip.v6.dst_port =
+						udp_spec->hdr.src_port;
 					flow_type =
 						ICE_FLTR_PTYPE_NONF_IPV6_UDP;
 				}