diff mbox series

ethdev: bump library version

Message ID 1572156845-29451-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series ethdev: bump library version |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand Oct. 27, 2019, 6:14 a.m. UTC 
  Let's stick to the current model of per library ABI version until the
new model is in place.

Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_ethdev/Makefile    | 2 +-
 lib/librte_ethdev/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Oct. 27, 2019, 9:02 a.m. UTC | #1 
27/10/2019 07:14, David Marchand:
> Let's stick to the current model of per library ABI version until the
> new model is in place.
> 
> Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

In order to make it more obvious, it would be nice to explain that
the ABI has changed and it is reflected in the release notes
but not in the compiled version number.

Acked-by: Thomas Monjalon <thomas@monjalon.net>
David Marchand Oct. 27, 2019, 9:43 a.m. UTC | #2 
On Sun, Oct 27, 2019 at 10:02 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 27/10/2019 07:14, David Marchand:
> > Let's stick to the current model of per library ABI version until the
> > new model is in place.
> >
> > Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> In order to make it more obvious, it would be nice to explain that
> the ABI has changed and it is reflected in the release notes
> but not in the compiled version number.

Ok, done.

>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



--
David Marchand
Andrew Rybchenko Oct. 28, 2019, 8:26 a.m. UTC | #3 
On 10/27/19 9:14 AM, David Marchand wrote:
> Let's stick to the current model of per library ABI version until the
> new model is in place.
>
> Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Thanks.
diff mbox series

Patch

diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile
index 60bcc22..0efcdfa 100644
--- a/lib/librte_ethdev/Makefile
+++ b/lib/librte_ethdev/Makefile
@@ -16,7 +16,7 @@  LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter
 
 EXPORT_MAP := rte_ethdev_version.map
 
-LIBABIVER := 12
+LIBABIVER := 13
 
 SRCS-y += ethdev_private.c
 SRCS-y += rte_ethdev.c
diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
index f75d428..c22cf81 100644
--- a/lib/librte_ethdev/meson.build
+++ b/lib/librte_ethdev/meson.build
@@ -2,7 +2,7 @@ 
 # Copyright(c) 2017 Intel Corporation
 
 name = 'ethdev'
-version = 12
+version = 13
 allow_experimental_apis = true
 sources = files('ethdev_private.c',
 	'ethdev_profile.c',