[2/2] mk: disable OcteonTx2 on old compilers

Message ID 20191028112535.692-2-alialnu@mellanox.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] mk: fix build on arm64 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/travis-robot success Travis build: passed

Commit Message

Ali Alnubani Oct. 28, 2019, 11:25 a.m. UTC
  This disables OcteonTx2 for gcc 4.8.5 as the compiler is
emitting "internal compiler error" for aarch64.

Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Jerin Jacob Oct. 30, 2019, 11:49 a.m. UTC | #1
On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote:
>
> This disables OcteonTx2 for gcc 4.8.5 as the compiler is
> emitting "internal compiler error" for aarch64.
>
> Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
>  mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
> index 00d6fd642..dd2c4e5da 100644
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -104,6 +104,9 @@ else
>                 CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
>                 CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
>                 CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> +               CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d
> +               CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d
> +               CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d

# Please add the following config also as there may be a connection in future
CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO=d
CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV=d

# s/OcteonTx2/OCTEON TX2/g in git commit and subject

With the above change:
Acked-by: Jerin Jacob <jerinj@marvell.com>



>         endif
>         endif
>
> --
> 2.23.0
>
  

Patch

diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 00d6fd642..dd2c4e5da 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -104,6 +104,9 @@  else
 		CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
+		CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d
+		CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d
+		CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d
 	endif
 	endif