diff mbox series

[v2] vhost: fix compile error

Message ID 20191030094055.37889-1-jin.yu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series [v2] vhost: fix compile error |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Jin Yu Oct. 30, 2019, 9:40 a.m. UTC 
  Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.

Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: stable@dpdk.org

Signed-off-by: Jin Yu <jin.yu@intel.com>
---
V2 - add the librte_crytodev
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tiwei Bie Nov. 4, 2019, 4:41 a.m. UTC | #1 
On Wed, Oct 30, 2019 at 05:40:55PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Maxime Coquelin Nov. 6, 2019, 7:52 p.m. UTC | #2 
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin Nov. 6, 2019, 7:59 p.m. UTC | #3 
Hi Jin,

On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..b2a143d4f 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
>  DEPDIRS-librte_rawdev := librte_eal librte_ethdev
>  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> -			librte_net
> +			librte_net librte_hash librte_cryptodev
>  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
>  DEPDIRS-librte_hash := librte_eal librte_ring
>  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> 

http://mails.dpdk.org/archives/test-report/2019-October/105347.html

The Intel compilation reports a breakage with this patch, and the
breakage happens in some crypto drivers. Could you please check it
is not a regression due to your patch?


*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
  CC zlib_pmd.o.pmd.o
  LD qat_device.o
  LD zlib_pmd.o
  CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
  CC hw_atl_b0.o
  CC qat_logs.o
  CC zlib_pmd_ops.o
  CC rte_pmd_atlantic.o
--
  CC axgbe_rxtx_vec_sse.o
  AR librte_pmd_octeontx_crypto.a
  AR librte_pmd_bond.a
  INSTALL-LIB librte_pmd_octeontx_crypto.a
  INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
  CC dpaa2_mux.o
== Build drivers/net/ena
  CC dpaa2_sparser.o
  CC mc/dpni.o
--
  CC hunt_nic.o
  CC medford_nic.o
  CC medford2_nic.o
  AR librte_pmd_sfc_efx.a
  INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
David Marchand Nov. 6, 2019, 8:05 p.m. UTC | #4 
Maxime,

On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> Hi Jin,
>
> On 10/30/19 10:40 AM, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> > So we need the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 356
> > Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> > V2 - add the librte_crytodev
> > ---
> >  lib/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 41c463d92..b2a143d4f 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
> >  DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> >  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
> >  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> > -                     librte_net
> > +                     librte_net librte_hash librte_cryptodev
> >  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> >  DEPDIRS-librte_hash := librte_eal librte_ring
> >  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> >
>
> http://mails.dpdk.org/archives/test-report/2019-October/105347.html
>
> The Intel compilation reports a breakage with this patch, and the
> breakage happens in some crypto drivers. Could you please check it
> is not a regression due to your patch?

Should be fixed with:
https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84

>
>
> *Make Build Failed #1:
> OS: CENTOS76-64
> Target: x86_64-native-linuxapp-clang
>   CC zlib_pmd.o.pmd.o
>   LD qat_device.o
>   LD zlib_pmd.o
>   CC hw_atl_utils_fw2x.o
> 1 error generated.
> make[6]: *** [dpaa2_sec_dpseci.o] Error 1
> make[5]: *** [dpaa2_sec] Error 2
> make[5]: *** Waiting for unfinished jobs....
>   CC hw_atl_b0.o
>   CC qat_logs.o
>   CC zlib_pmd_ops.o
>   CC rte_pmd_atlantic.o
> --
>   CC axgbe_rxtx_vec_sse.o
>   AR librte_pmd_octeontx_crypto.a
>   AR librte_pmd_bond.a
>   INSTALL-LIB librte_pmd_octeontx_crypto.a
>   INSTALL-LIB librte_pmd_bond.a
> make[4]: *** [crypto] Error 2
> make[4]: *** Waiting for unfinished jobs....
>   CC dpaa2_mux.o
> == Build drivers/net/ena
>   CC dpaa2_sparser.o
>   CC mc/dpni.o
> --
>   CC hunt_nic.o
>   CC medford_nic.o
>   CC medford2_nic.o
>   AR librte_pmd_sfc_efx.a
>   INSTALL-LIB librte_pmd_sfc_efx.a
> make[3]: *** [drivers] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [pre_install] Error 2
> make: *** [install] Error 2
>
Maxime Coquelin Nov. 6, 2019, 8:30 p.m. UTC | #5 
On 11/6/19 9:05 PM, David Marchand wrote:
> Maxime,
> 
> On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> Hi Jin,
>>
>> On 10/30/19 10:40 AM, Jin Yu wrote:
>>> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
>>> So we need the librte_hash to be compiled before vhost.
>>> Add the DEPDIRs to make sure this.
>>>
>>> Bugzilla ID: 356
>>> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Jin Yu <jin.yu@intel.com>
>>> ---
>>> V2 - add the librte_crytodev
>>> ---
>>>  lib/Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/Makefile b/lib/Makefile
>>> index 41c463d92..b2a143d4f 100644
>>> --- a/lib/Makefile
>>> +++ b/lib/Makefile
>>> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
>>>  DEPDIRS-librte_rawdev := librte_eal librte_ethdev
>>>  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>>>  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
>>> -                     librte_net
>>> +                     librte_net librte_hash librte_cryptodev
>>>  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
>>>  DEPDIRS-librte_hash := librte_eal librte_ring
>>>  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
>>>
>>
>> http://mails.dpdk.org/archives/test-report/2019-October/105347.html
>>
>> The Intel compilation reports a breakage with this patch, and the
>> breakage happens in some crypto drivers. Could you please check it
>> is not a regression due to your patch?
> 
> Should be fixed with:
> https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84

Thanks David! Then it is ok to me.

> 
>>
>>
>> *Make Build Failed #1:
>> OS: CENTOS76-64
>> Target: x86_64-native-linuxapp-clang
>>   CC zlib_pmd.o.pmd.o
>>   LD qat_device.o
>>   LD zlib_pmd.o
>>   CC hw_atl_utils_fw2x.o
>> 1 error generated.
>> make[6]: *** [dpaa2_sec_dpseci.o] Error 1
>> make[5]: *** [dpaa2_sec] Error 2
>> make[5]: *** Waiting for unfinished jobs....
>>   CC hw_atl_b0.o
>>   CC qat_logs.o
>>   CC zlib_pmd_ops.o
>>   CC rte_pmd_atlantic.o
>> --
>>   CC axgbe_rxtx_vec_sse.o
>>   AR librte_pmd_octeontx_crypto.a
>>   AR librte_pmd_bond.a
>>   INSTALL-LIB librte_pmd_octeontx_crypto.a
>>   INSTALL-LIB librte_pmd_bond.a
>> make[4]: *** [crypto] Error 2
>> make[4]: *** Waiting for unfinished jobs....
>>   CC dpaa2_mux.o
>> == Build drivers/net/ena
>>   CC dpaa2_sparser.o
>>   CC mc/dpni.o
>> --
>>   CC hunt_nic.o
>>   CC medford_nic.o
>>   CC medford2_nic.o
>>   AR librte_pmd_sfc_efx.a
>>   INSTALL-LIB librte_pmd_sfc_efx.a
>> make[3]: *** [drivers] Error 2
>> make[2]: *** [all] Error 2
>> make[1]: *** [pre_install] Error 2
>> make: *** [install] Error 2
>>
> 
>
Maxime Coquelin Nov. 6, 2019, 8:59 p.m. UTC | #6 
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied to dpdk-next-virtio/master.

Thanks,
Maxime
diff mbox series

Patch

diff --git a/lib/Makefile b/lib/Makefile
index 41c463d92..b2a143d4f 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -46,7 +46,7 @@  DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd