diff mbox series

port: fix library build order dependency

Message ID 20191105194210.5222-1-rahul.r.shah@intel.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series port: fix library build order dependency |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation fail Compilation issues

Commit Message

Rahul Shah Nov. 5, 2019, 7:42 p.m. UTC 
  The port library should be build after eventdev library.

Fixes: 	5d92c4e5 ("port: add eventdev port type")

Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
---
 lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Cristian Dumitrescu Nov. 7, 2019, 9:11 a.m. UTC | #1 
> -----Original Message-----
> From: Shah, Rahul R <rahul.r.shah@intel.com>
> Sent: Tuesday, November 5, 2019 7:42 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] port: fix library build order dependency
> 
> The port library should be build after eventdev library.
> 
> Fixes: 	5d92c4e5 ("port: add eventdev port type")
> 
> Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 5d04ab915..2c2b80ac3 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -90,6 +90,7 @@ DEPDIRS-librte_distributor := librte_eal librte_mbuf
> librte_ethdev
>  DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port
>  DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev
>  DEPDIRS-librte_port += librte_ip_frag librte_sched
> +DEPDIRS-librte_port += librte_eventdev
>  ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
>  DEPDIRS-librte_port += librte_kni
>  endif
> --
> 2.20.1

Cosmetically, you might want to squeeze & add librte_eventdev on the line immediately above.
Ferruh Yigit Nov. 7, 2019, 2:19 p.m. UTC | #2 
On 11/5/2019 7:42 PM, Rahul Shah wrote:
> The port library should be build after eventdev library.
> 
> Fixes: 	5d92c4e5 ("port: add eventdev port type")
> 
> Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
diff mbox series

Patch

diff --git a/lib/Makefile b/lib/Makefile
index 5d04ab915..2c2b80ac3 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -90,6 +90,7 @@  DEPDIRS-librte_distributor := librte_eal librte_mbuf librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port
 DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev
 DEPDIRS-librte_port += librte_ip_frag librte_sched
+DEPDIRS-librte_port += librte_eventdev
 ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
 DEPDIRS-librte_port += librte_kni
 endif