diff mbox series

examples/l2fwd: fix build warning with system wide install

Message ID 1573562253-10332-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series examples/l2fwd: fix build warning with system wide install |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

David Marchand Nov. 12, 2019, 12:37 p.m. UTC 
  Caught when compiling this example with pkg-config:

 ## Building l2fwd
 ...
 main.c: In function ‘main’:
 main.c:716:3: warning: ‘rte_eth_dev_set_ptypes’ is deprecated: Symbol
 is not yet part of stable ABI [-Wdeprecated-declarations]
   716 |   ret = rte_eth_dev_set_ptypes(portid, RTE_PTYPE_UNKNOWN, NULL,
       |   ^~~
 In file included from main.c:38:
 ...build-x86-default/install-root/usr/local/include/rte_ethdev.h:2661:5:
 note: declared here
  2661 | int rte_eth_dev_set_ptypes(uint16_t port_id, uint32_t
 ptype_mask,
       |     ^~~~~~~~~~~~~~~~~~~~~~
 ln -sf l2fwd-shared build/l2fwd

Fixes: 9731df2e7554 ("examples/l2fwd: disable packet type parsing")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 examples/l2fwd/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ferruh Yigit Nov. 12, 2019, 5:09 p.m. UTC | #1 
On 11/12/2019 12:37 PM, David Marchand wrote:
> Caught when compiling this example with pkg-config:
> 
>  ## Building l2fwd
>  ...
>  main.c: In function ‘main’:
>  main.c:716:3: warning: ‘rte_eth_dev_set_ptypes’ is deprecated: Symbol
>  is not yet part of stable ABI [-Wdeprecated-declarations]
>    716 |   ret = rte_eth_dev_set_ptypes(portid, RTE_PTYPE_UNKNOWN, NULL,
>        |   ^~~
>  In file included from main.c:38:
>  ...build-x86-default/install-root/usr/local/include/rte_ethdev.h:2661:5:
>  note: declared here
>   2661 | int rte_eth_dev_set_ptypes(uint16_t port_id, uint32_t
>  ptype_mask,
>        |     ^~~~~~~~~~~~~~~~~~~~~~
>  ln -sf l2fwd-shared build/l2fwd
> 
> Fixes: 9731df2e7554 ("examples/l2fwd: disable packet type parsing")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
David Marchand Nov. 12, 2019, 7:13 p.m. UTC | #2 
On Tue, Nov 12, 2019 at 6:09 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 11/12/2019 12:37 PM, David Marchand wrote:
> > Caught when compiling this example with pkg-config:
> >
> >  ## Building l2fwd
> >  ...
> >  main.c: In function ‘main’:
> >  main.c:716:3: warning: ‘rte_eth_dev_set_ptypes’ is deprecated: Symbol
> >  is not yet part of stable ABI [-Wdeprecated-declarations]
> >    716 |   ret = rte_eth_dev_set_ptypes(portid, RTE_PTYPE_UNKNOWN, NULL,
> >        |   ^~~
> >  In file included from main.c:38:
> >  ...build-x86-default/install-root/usr/local/include/rte_ethdev.h:2661:5:
> >  note: declared here
> >   2661 | int rte_eth_dev_set_ptypes(uint16_t port_id, uint32_t
> >  ptype_mask,
> >        |     ^~~~~~~~~~~~~~~~~~~~~~
> >  ln -sf l2fwd-shared build/l2fwd
> >
> > Fixes: 9731df2e7554 ("examples/l2fwd: disable packet type parsing")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Thanks.
Applied.



--
David Marchand
diff mbox series

Patch

diff --git a/examples/l2fwd/Makefile b/examples/l2fwd/Makefile
index 59b2b4a..9c50684 100644
--- a/examples/l2fwd/Makefile
+++ b/examples/l2fwd/Makefile
@@ -21,6 +21,8 @@  PKGCONF=pkg-config --define-prefix
 
 PC_FILE := $(shell $(PKGCONF) --path libdpdk)
 CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)
+# Add flag to allow experimental API as l2fwd uses rte_ethdev_set_ptype API
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)
 LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)