diff mbox series

ci: add minimal check on testpmd

Message ID 20191122155429.18971-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ci: add minimal check on testpmd |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail Compilation issues

Commit Message

David Marchand Nov. 22, 2019, 3:54 p.m. UTC 
  Try to start testpmd with two vdevs without hugepages.
This is a really basic check, but better than nothing.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .ci/linux-build.sh | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon Nov. 22, 2019, 4:29 p.m. UTC | #1 
22/11/2019 16:54, David Marchand:
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> +if [ "$AARCH64" != "1" ]; then
> +    ./devtools/test-null.sh

You are missing the build directory as first parameter,
otherwise it won't find testpmd.

One nit: ./ is probably useless.
David Marchand Nov. 24, 2019, 2:17 p.m. UTC | #2 
On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/11/2019 16:54, David Marchand:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > +if [ "$AARCH64" != "1" ]; then
> > +    ./devtools/test-null.sh
>
> You are missing the build directory as first parameter,
> otherwise it won't find testpmd.

This parameter is optional.
In test-null.sh:
build=${1:-build} # first argument can be the build directory

travis builds in this directory.

I suppose you noticed that the jobs in travis were all failing, but
this is because the fix [1] on testpmd is not in master yet.
1: https://patchwork.dpdk.org/patch/63226/


>
> One nit: ./ is probably useless.

No strong opinion.
Thomas Monjalon Nov. 24, 2019, 6:12 p.m. UTC | #3 
24/11/2019 15:17, David Marchand:
> On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/11/2019 16:54, David Marchand:
> > > --- a/.ci/linux-build.sh
> > > +++ b/.ci/linux-build.sh
> > > +if [ "$AARCH64" != "1" ]; then
> > > +    ./devtools/test-null.sh
> >
> > You are missing the build directory as first parameter,
> > otherwise it won't find testpmd.
> 
> This parameter is optional.
> In test-null.sh:
> build=${1:-build} # first argument can be the build directory
> 
> travis builds in this directory.

Oh right.
It's funny, because I wrote it and forgot :)

> I suppose you noticed that the jobs in travis were all failing, but
> this is because the fix [1] on testpmd is not in master yet.
> 1: https://patchwork.dpdk.org/patch/63226/

I will pull next-net soon.

> > One nit: ./ is probably useless.
> 
> No strong opinion.
Thomas Monjalon Nov. 26, 2019, 10:41 p.m. UTC | #4 
24/11/2019 19:12, Thomas Monjalon:
> 24/11/2019 15:17, David Marchand:
> > On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 22/11/2019 16:54, David Marchand:
> > > > --- a/.ci/linux-build.sh
> > > > +++ b/.ci/linux-build.sh
> > > > +if [ "$AARCH64" != "1" ]; then
> > > > +    ./devtools/test-null.sh
> > >
> > > You are missing the build directory as first parameter,
> > > otherwise it won't find testpmd.
> > 
> > This parameter is optional.
> > In test-null.sh:
> > build=${1:-build} # first argument can be the build directory
> > 
> > travis builds in this directory.
> 
> Oh right.
> It's funny, because I wrote it and forgot :)
> 
> > I suppose you noticed that the jobs in travis were all failing, but
> > this is because the fix [1] on testpmd is not in master yet.
> > 1: https://patchwork.dpdk.org/patch/63226/
> 
> I will pull next-net soon.
> 
> > > One nit: ./ is probably useless.
> > 
> > No strong opinion.

Applied (without ./), thanks
diff mbox series

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index c570ba24e6..e37176e91c 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -32,6 +32,10 @@  OPTS="$OPTS --default-library=$DEF_LIB"
 meson build --werror -Dexamples=all $OPTS
 ninja -C build
 
+if [ "$AARCH64" != "1" ]; then
+    ./devtools/test-null.sh
+fi
+
 if [ "$RUN_TESTS" = "1" ]; then
     sudo meson test -C build --suite fast-tests -t 3
 fi