examples/ioat: handle error when querying number of stats
Checks
Commit Message
To get the amount of memory needed for stats, we call the xstats_get_names
function with a NULL parameter, which can return -1 on error. This negative
value was not previously handled correctly, so we adjust things to quit the
stats printing routine if this basic call fails.
Coverity issue: 350346
Fixes: 632bcd9b5d4f ("examples/ioat: print statistics")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
examples/ioat/ioatfwd.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Comments
On Mon, Nov 25, 2019 at 4:36 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> To get the amount of memory needed for stats, we call the xstats_get_names
> function with a NULL parameter, which can return -1 on error. This negative
> value was not previously handled correctly, so we adjust things to quit the
> stats printing routine if this basic call fails.
>
> Coverity issue: 350346
> Fixes: 632bcd9b5d4f ("examples/ioat: print statistics")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
@@ -170,7 +170,7 @@ print_stats(char *prgname)
unsigned int *ids_xstats, nb_xstats;
char status_string[120]; /* to print at the top of the output */
int status_strlen;
-
+ int ret;
const char clr[] = { 27, '[', '2', 'J', '\0' };
const char topLeft[] = { 27, '[', '1', ';', '1', 'H', '\0' };
@@ -197,8 +197,11 @@ print_stats(char *prgname)
"Ring Size = %d\n", ring_size);
/* Allocate memory for xstats names and values */
- nb_xstats = rte_rawdev_xstats_names_get(
+ ret = rte_rawdev_xstats_names_get(
cfg.ports[0].ioat_ids[0], NULL, 0);
+ if (ret < 0)
+ return;
+ nb_xstats = (unsigned int)ret;
names_xstats = malloc(sizeof(*names_xstats) * nb_xstats);
if (names_xstats == NULL) {