diff mbox series

build: install missing header files

Message ID 20191126081637.23008-1-alialnu@mellanox.com (mailing list archive)
State Superseded, archived
Headers
Series build: install missing header files |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Ali Alnubani Nov. 26, 2019, 8:16 a.m. UTC 
  The following header files weren't being installed by meson:
  - rte_vfio.h
  - rte_function_versioning.h
  - rte_test.h

This patch adds them to the common_headers list so that
they are installed.

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 lib/librte_eal/common/meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Nov. 26, 2019, 9:34 a.m. UTC | #1 
The title should mention EAL:
	eal: fix header files install with meson

26/11/2019 09:16, Ali Alnubani:
> The following header files weren't being installed by meson:
>   - rte_vfio.h
>   - rte_function_versioning.h
>   - rte_test.h
> 
> This patch adds them to the common_headers list so that
> they are installed.

Please add the "Fixes:" references.

> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
>  lib/librte_eal/common/meson.build | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Bruce Richardson Nov. 26, 2019, 9:52 a.m. UTC | #2 
On Tue, Nov 26, 2019 at 10:34:11AM +0100, Thomas Monjalon wrote:
> The title should mention EAL:
> 	eal: fix header files install with meson
> 
> 26/11/2019 09:16, Ali Alnubani:
> > The following header files weren't being installed by meson:
> >   - rte_vfio.h
> >   - rte_function_versioning.h
> >   - rte_test.h
> > 
> > This patch adds them to the common_headers list so that
> > they are installed.
> 
> Please add the "Fixes:" references.
> 
> > Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> > ---
> >  lib/librte_eal/common/meson.build | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
diff mbox series

Patch

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index d6a149bec..71d0c50ce 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -64,6 +64,7 @@  common_headers = files(
 	'include/rte_eal_interrupts.h',
 	'include/rte_errno.h',
 	'include/rte_fbarray.h',
+	'include/rte_function_versioning.h',
 	'include/rte_hexdump.h',
 	'include/rte_hypervisor.h',
 	'include/rte_interrupts.h',
@@ -84,9 +85,11 @@  common_headers = files(
 	'include/rte_service_component.h',
 	'include/rte_string_fns.h',
 	'include/rte_tailq.h',
+	'include/rte_test.h',
 	'include/rte_time.h',
 	'include/rte_uuid.h',
-	'include/rte_version.h')
+	'include/rte_version.h',
+	'include/rte_vfio.h')
 
 # special case install the generic headers, since they go in a subdir
 generic_headers = files(