diff mbox series

[v2] eal: fix header files install with meson

Message ID 20191126105028.24948-1-alialnu@mellanox.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series [v2] eal: fix header files install with meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed

Commit Message

Ali Alnubani Nov. 26, 2019, 10:51 a.m. UTC 
  The following header files weren't being installed by meson:
  - rte_vfio.h
  - rte_function_versioning.h
  - rte_test.h

This patch adds them to the common_headers list so that
they are installed.

Fixes: 610beca42ea4 ("build: remove library special cases")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: updated commit title and added a fixes tag.

 lib/librte_eal/common/meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Nov. 26, 2019, 11:17 a.m. UTC | #1 
26/11/2019 11:51, Ali Alnubani:
> The following header files weren't being installed by meson:
>   - rte_vfio.h
>   - rte_function_versioning.h
>   - rte_test.h
> 
> This patch adds them to the common_headers list so that
> they are installed.
> 
> Fixes: 610beca42ea4 ("build: remove library special cases")

I am not sure this is the right root cause.
At least for rte_function_versioning.h, it has been added recently.

> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Bruce Richardson Nov. 26, 2019, 1:25 p.m. UTC | #2 
On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote:
> 26/11/2019 11:51, Ali Alnubani:
> > The following header files weren't being installed by meson:
> >   - rte_vfio.h
> >   - rte_function_versioning.h
> >   - rte_test.h
> > 
> > This patch adds them to the common_headers list so that
> > they are installed.
> > 
> > Fixes: 610beca42ea4 ("build: remove library special cases")
> 
> I am not sure this is the right root cause.
> At least for rte_function_versioning.h, it has been added recently.
> 

Thanks for pointing this out. The rte_function_versioning.h file I
deliberately omitted from the meson install since it's really for internal
use only. It's not really recommended for external app use, since it relies
on some DPDK defines etc.

> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> 
>
diff mbox series

Patch

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index d6a149bec..71d0c50ce 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -64,6 +64,7 @@  common_headers = files(
 	'include/rte_eal_interrupts.h',
 	'include/rte_errno.h',
 	'include/rte_fbarray.h',
+	'include/rte_function_versioning.h',
 	'include/rte_hexdump.h',
 	'include/rte_hypervisor.h',
 	'include/rte_interrupts.h',
@@ -84,9 +85,11 @@  common_headers = files(
 	'include/rte_service_component.h',
 	'include/rte_string_fns.h',
 	'include/rte_tailq.h',
+	'include/rte_test.h',
 	'include/rte_time.h',
 	'include/rte_uuid.h',
-	'include/rte_version.h')
+	'include/rte_version.h',
+	'include/rte_vfio.h')
 
 # special case install the generic headers, since they go in a subdir
 generic_headers = files(