diff mbox series

[v1] net/ice: add new device IDs

Message ID 540abe7cc9f9f374cfe17fb28a7159bb5a3877bc.1576664958.git.ting.xu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series [v1] net/ice: add new device IDs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK

Commit Message

Xu, Ting Dec. 18, 2019, 12:41 p.m. UTC 
  This patch added new device IDs for C822N.

Signed-off-by: Ting Xu <ting.xu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Xiaolong Ye Dec. 19, 2019, 2:43 a.m. UTC | #1 
On 12/18, Ting Xu wrote:
>This patch added new device IDs for C822N.
>
>Signed-off-by: Ting Xu <ting.xu@intel.com>
>---
> drivers/net/ice/ice_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index de189daba..2cbd82c94 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -163,6 +163,9 @@ static const struct rte_pci_id pci_id_ice_map[] = {
> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_BACKPLANE) },
> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_QSFP) },
> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_SFP) },
>+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_BACKPLANE) },
>+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_QSFP) },
>+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_SFP) },
> 	{ .vendor_id = 0, /* sentinel */ },
> };
> 
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
Ferruh Yigit Dec. 19, 2019, 12:13 p.m. UTC | #2 
On 12/19/2019 2:43 AM, Ye Xiaolong wrote:
> On 12/18, Ting Xu wrote:
>> This patch added new device IDs for C822N.
>>
>> Signed-off-by: Ting Xu <ting.xu@intel.com>
>> ---
>> drivers/net/ice/ice_ethdev.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>> index de189daba..2cbd82c94 100644
>> --- a/drivers/net/ice/ice_ethdev.c
>> +++ b/drivers/net/ice/ice_ethdev.c
>> @@ -163,6 +163,9 @@ static const struct rte_pci_id pci_id_ice_map[] = {
>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_BACKPLANE) },
>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_QSFP) },
>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_SFP) },
>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_BACKPLANE) },
>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_QSFP) },
>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_SFP) },
>> 	{ .vendor_id = 0, /* sentinel */ },
>> };
>>
>> -- 
>> 2.17.1
>>
> 
> Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Applied to dpdk-next-net-intel, Thanks.
> 

Just to double check, if this requires any update in the NIC documentation?
Xu, Ting Dec. 20, 2019, 7:01 a.m. UTC | #3 
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Thursday, December 19, 2019 8:14 PM
> To: Ye, Xiaolong <xiaolong.ye@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: add new device IDs
> 
> On 12/19/2019 2:43 AM, Ye Xiaolong wrote:
> > On 12/18, Ting Xu wrote:
> >> This patch added new device IDs for C822N.
> >>
> >> Signed-off-by: Ting Xu <ting.xu@intel.com>
> >> ---
> >> drivers/net/ice/ice_ethdev.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/net/ice/ice_ethdev.c
> >> b/drivers/net/ice/ice_ethdev.c index de189daba..2cbd82c94 100644
> >> --- a/drivers/net/ice/ice_ethdev.c
> >> +++ b/drivers/net/ice/ice_ethdev.c
> >> @@ -163,6 +163,9 @@ static const struct rte_pci_id pci_id_ice_map[] = {
> >> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E810_XXV_BACKPLANE) },
> >> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E810_XXV_QSFP) },
> >> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E810_XXV_SFP) },
> >> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_C822N_BACKPLANE) },
> >> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_QSFP) },
> >> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_SFP) },
> >> 	{ .vendor_id = 0, /* sentinel */ },
> >> };
> >>
> >> --
> >> 2.17.1
> >>
> >
> > Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> > Applied to dpdk-next-net-intel, Thanks.
> >
> 
> Just to double check, if this requires any update in the NIC documentation?

Hi, Ferruh, I will update docs for ice supported NICs to add C822 later. And is it necessary to update the 20.02 release note as well?
Ferruh Yigit Dec. 20, 2019, 8:54 a.m. UTC | #4 
On 12/20/2019 7:01 AM, Xu, Ting wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Thursday, December 19, 2019 8:14 PM
>> To: Ye, Xiaolong <xiaolong.ye@intel.com>; Xu, Ting <ting.xu@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: add new device IDs
>>
>> On 12/19/2019 2:43 AM, Ye Xiaolong wrote:
>>> On 12/18, Ting Xu wrote:
>>>> This patch added new device IDs for C822N.
>>>>
>>>> Signed-off-by: Ting Xu <ting.xu@intel.com>
>>>> ---
>>>> drivers/net/ice/ice_ethdev.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/net/ice/ice_ethdev.c
>>>> b/drivers/net/ice/ice_ethdev.c index de189daba..2cbd82c94 100644
>>>> --- a/drivers/net/ice/ice_ethdev.c
>>>> +++ b/drivers/net/ice/ice_ethdev.c
>>>> @@ -163,6 +163,9 @@ static const struct rte_pci_id pci_id_ice_map[] = {
>>>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
>> ICE_DEV_ID_E810_XXV_BACKPLANE) },
>>>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
>> ICE_DEV_ID_E810_XXV_QSFP) },
>>>> 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
>> ICE_DEV_ID_E810_XXV_SFP) },
>>>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
>> ICE_DEV_ID_C822N_BACKPLANE) },
>>>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_QSFP) },
>>>> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_SFP) },
>>>> 	{ .vendor_id = 0, /* sentinel */ },
>>>> };
>>>>
>>>> --
>>>> 2.17.1
>>>>
>>>
>>> Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>>
>>> Applied to dpdk-next-net-intel, Thanks.
>>>
>>
>> Just to double check, if this requires any update in the NIC documentation?
> 
> Hi, Ferruh, I will update docs for ice supported NICs to add C822 later.
>

Thanks.

>
> And is it necessary to update the 20.02 release note as well?
> 

Optional, up to you, but why not put a brief single line to mention from it.
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index de189daba..2cbd82c94 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -163,6 +163,9 @@  static const struct rte_pci_id pci_id_ice_map[] = {
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_BACKPLANE) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_QSFP) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810_XXV_SFP) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_BACKPLANE) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_QSFP) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C822N_SFP) },
 	{ .vendor_id = 0, /* sentinel */ },
 };