diff mbox series

[v9,4/4] net/e1000: cleanup Tx buffers

Message ID 20200113095708.67598-5-chenxux.di@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series drivers/net: cleanup Tx buffers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed

Commit Message

Chenxu Di Jan. 13, 2020, 9:57 a.m. UTC 
  Add support to the igb vf for the API rte_eth_tx_done_cleanup
 to force free consumed buffers on Tx ring.

Signed-off-by: Chenxu Di <chenxux.di@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ananyev, Konstantin Jan. 13, 2020, 11:08 a.m. UTC | #1 
> 
> Add support to the igb vf for the API rte_eth_tx_done_cleanup
>  to force free consumed buffers on Tx ring.
> 
> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index a3e30dbe5..647d5504f 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -446,6 +446,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {
>  	.tx_descriptor_status = eth_igb_tx_descriptor_status,
>  	.tx_queue_setup       = eth_igb_tx_queue_setup,
>  	.tx_queue_release     = eth_igb_tx_queue_release,
> +	.tx_done_cleanup      = eth_igb_tx_done_cleanup,
>  	.set_mc_addr_list     = eth_igb_set_mc_addr_list,
>  	.rxq_info_get         = igb_rxq_info_get,
>  	.txq_info_get         = igb_txq_info_get,
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1
Xiaolong Ye Jan. 14, 2020, 2:49 a.m. UTC | #2 
On 01/13, Chenxu Di wrote:
>Add support to the igb vf for the API rte_eth_tx_done_cleanup
> to force free consumed buffers on Tx ring.
>
>Signed-off-by: Chenxu Di <chenxux.di@intel.com>
>---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index a3e30dbe5..647d5504f 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c

What about em_ethdev.c in e1000 dir, do we need to add support as well?

Thanks,
Xiaolong
>@@ -446,6 +446,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {
> 	.tx_descriptor_status = eth_igb_tx_descriptor_status,
> 	.tx_queue_setup       = eth_igb_tx_queue_setup,
> 	.tx_queue_release     = eth_igb_tx_queue_release,
>+	.tx_done_cleanup      = eth_igb_tx_done_cleanup,
> 	.set_mc_addr_list     = eth_igb_set_mc_addr_list,
> 	.rxq_info_get         = igb_rxq_info_get,
> 	.txq_info_get         = igb_txq_info_get,
>-- 
>2.17.1
>
diff mbox series

Patch

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index a3e30dbe5..647d5504f 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -446,6 +446,7 @@  static const struct eth_dev_ops igbvf_eth_dev_ops = {
 	.tx_descriptor_status = eth_igb_tx_descriptor_status,
 	.tx_queue_setup       = eth_igb_tx_queue_setup,
 	.tx_queue_release     = eth_igb_tx_queue_release,
+	.tx_done_cleanup      = eth_igb_tx_done_cleanup,
 	.set_mc_addr_list     = eth_igb_set_mc_addr_list,
 	.rxq_info_get         = igb_rxq_info_get,
 	.txq_info_get         = igb_txq_info_get,