drivers/crypto: fix set_sym_session_private_data error in sessionless mode
Checks
Commit Message
When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode
for symmetric crypto operation (e.g. SHA256 hash), the driver prints
error message:
CRYPTODEV: set_sym_session_private_data() line 489:
Set private data for driver 0 not allowed
Then, AESNI-MB driver segfaults in post_process_mb_job().
Bugzilla ID: 377
Fixes: b3bbd9e ("cryptodev: support device independent sessions")
Fixes: c68d7aa ("crypto/aesni_mb: use architecture independent macros")
Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++--
drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.7.4
Comments
Hi Pablo,
> When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode
> for symmetric crypto operation (e.g. SHA256 hash), the driver prints
> error message:
>
> CRYPTODEV: set_sym_session_private_data() line 489:
> Set private data for driver 0 not allowed
>
> Then, AESNI-MB driver segfaults in post_process_mb_job().
>
> Bugzilla ID: 377
> Fixes: b3bbd9e ("cryptodev: support device independent sessions")
> Fixes: c68d7aa ("crypto/aesni_mb: use architecture independent macros")
>
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
Could you please Ack this patch of no issues?
>
> When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode
> for symmetric crypto operation (e.g. SHA256 hash), the driver prints
> error message:
>
> CRYPTODEV: set_sym_session_private_data() line 489:
> Set private data for driver 0 not allowed
>
> Then, AESNI-MB driver segfaults in post_process_mb_job().
>
> Bugzilla ID: 377
> Fixes: b3bbd9e ("cryptodev: support device independent sessions")
> Fixes: c68d7aa ("crypto/aesni_mb: use architecture independent macros")
>
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
Applied to dpdk-next-crypto
Thanks.
@@ -729,10 +729,10 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_op *op)
op->sym->session,
cryptodev_driver_id);
} else {
- void *_sess = NULL;
+ void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp);
void *_sess_private_data = NULL;
- if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+ if (_sess == NULL)
return NULL;
if (rte_mempool_get(qp->sess_mp_priv,
@@ -762,10 +762,10 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op *op)
return NULL;
/* provide internal session */
- void *_sess = NULL;
+ void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp);
void *_sess_private_data = NULL;
- if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+ if (_sess == NULL)
return NULL;
if (rte_mempool_get(qp->sess_mp_priv,