[v2] net/bnxt: fix to remove spurious warning in Rx handler
Checks
Commit Message
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: 94eb699bc82e ("net/bnxt: support flow mark action")
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
v1->v2: Used the correct commit id for the fixes tag
drivers/net/bnxt/bnxt_rxr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Comments
On Thu, Jan 30, 2020 at 10:18 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> HW seems to populate the cfa code in the Rx descriptor even
> if an explicit flow rule is not configured via application as
> there might be a default rule configured in HW even for promisc
> mode.
>
> Fixes: 94eb699bc82e ("net/bnxt: support flow mark action")
>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
---
> v1->v2: Used the correct commit id for the fixes tag
> drivers/net/bnxt/bnxt_rxr.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 1960b05..1f47db9 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
> if (!cfa_code)
> return;
>
> - if (cfa_code && !bp->mark_table[cfa_code].valid) {
> - PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code:
> 0x%x\n",
> - cfa_code);
> + if (cfa_code && !bp->mark_table[cfa_code].valid)
> return;
> - }
>
> flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
> meta = rte_le_to_cpu_32(rxcmp1->metadata);
> --
> 1.8.3.1
>
>
@@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
if (!cfa_code)
return;
- if (cfa_code && !bp->mark_table[cfa_code].valid) {
- PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code: 0x%x\n",
- cfa_code);
+ if (cfa_code && !bp->mark_table[cfa_code].valid)
return;
- }
flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
meta = rte_le_to_cpu_32(rxcmp1->metadata);