diff mbox series

[2/2] ci: enable more drivers in Travis builds

Message ID 20200217113547.1889436-3-thomas@monjalon.net (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series improve Travis coverage |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot warning Travis build: errored
ci/Intel-compilation fail apply issues

Commit Message

Thomas Monjalon Feb. 17, 2020, 11:35 a.m. UTC 
  The Travis compilation is missing some dependencies to build these PMDs:
	- af_xdp (libbpf)
	- ipn3ke (libfdt)
	- mlx (libibverbs)

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole Feb. 17, 2020, 6 p.m. UTC | #1 
Thomas Monjalon <thomas@monjalon.net> writes:

> The Travis compilation is missing some dependencies to build these PMDs:
> 	- af_xdp (libbpf)
> 	- ipn3ke (libfdt)
> 	- mlx (libibverbs)
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

I was going to wait until travis finished to ACK this but I think it's
okay.  I'll check back in on it later.

Acked-by: Aaron Conole <aconole@redhat.com>

>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 19422d4b3c..bb32c8edcc 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -24,7 +24,7 @@ aarch64_packages: &aarch64_packages
>  
>  extra_packages: &extra_packages
>    - *required_packages
> -  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
> +  - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
>  
>  build_32b_packages: &build_32b_packages
>    - *required_packages
Thomas Monjalon Feb. 17, 2020, 9:19 p.m. UTC | #2 
17/02/2020 19:00, Aaron Conole:
> Thomas Monjalon <thomas@monjalon.net> writes:
> 
> > The Travis compilation is missing some dependencies to build these PMDs:
> > 	- af_xdp (libbpf)
> > 	- ipn3ke (libfdt)
> > 	- mlx (libibverbs)
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> I was going to wait until travis finished to ACK this but I think it's
> okay.  I'll check back in on it later.
> 
> Acked-by: Aaron Conole <aconole@redhat.com>
> 
> >  extra_packages: &extra_packages
> >    - *required_packages
> > -  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
> > +  - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]

It failed because libbpf is not available:
	Unable to locate package libbpf-dev

I will re-spin a v2 without libbpf (not enabling af_xdp PMD).
Aaron Conole Feb. 17, 2020, 9:38 p.m. UTC | #3 
Thomas Monjalon <thomas@monjalon.net> writes:

> 17/02/2020 19:00, Aaron Conole:
>> Thomas Monjalon <thomas@monjalon.net> writes:
>> 
>> > The Travis compilation is missing some dependencies to build these PMDs:
>> > 	- af_xdp (libbpf)
>> > 	- ipn3ke (libfdt)
>> > 	- mlx (libibverbs)
>> >
>> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> 
>> I was going to wait until travis finished to ACK this but I think it's
>> okay.  I'll check back in on it later.
>> 
>> Acked-by: Aaron Conole <aconole@redhat.com>
>> 
>> >  extra_packages: &extra_packages
>> >    - *required_packages
>> > -  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
>> > +  - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
>
> It failed because libbpf is not available:
> 	Unable to locate package libbpf-dev
>
> I will re-spin a v2 without libbpf (not enabling af_xdp PMD).

Okay.  Feel free to keep my ack :)
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index 19422d4b3c..bb32c8edcc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,7 +24,7 @@  aarch64_packages: &aarch64_packages
 
 extra_packages: &extra_packages
   - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
+  - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
 
 build_32b_packages: &build_32b_packages
   - *required_packages